Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 955563002: [Oilpan] Set stack limit using estimated sizes (Re-land) (Closed)

Created:
5 years, 10 months ago by peria
Modified:
5 years, 10 months ago
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Set the stack limit size based on estimated sizes. To check if the stack memory has enough room for recursive calls, we tried to allocate a large object and assumed the size. This CL estimate the real thread stack limit using APIs. On some platforms where such APIs do not work correctly, we set the limit using the old algorithm. On ASAN build, we disable it because sanitizer creates and uses "fake stacks". --- This CL is re-land of https://codereview.chromium.org/910663002/, https://codereview.chromium.org/927213002/, and https://codereview.chromium.org/943293002/. Test was changed in another CL. BUG=420515, 457982 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190738

Patch Set 1 #

Patch Set 2 : Disable on ASAN #

Patch Set 3 : Update comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -7 lines) Patch
M Source/platform/heap/StackFrameDepth.cpp View 1 2 3 chunks +48 lines, -6 lines 0 comments Download
M Source/platform/heap/ThreadState.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
peria
PTAL
5 years, 10 months ago (2015-02-24 09:03:05 UTC) #3
haraken
LGTM
5 years, 10 months ago (2015-02-24 09:09:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/955563002/40001
5 years, 10 months ago (2015-02-24 09:11:51 UTC) #6
kouhei (in TOK)
lgtm
5 years, 10 months ago (2015-02-24 10:28:43 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 10:32:42 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190738

Powered by Google App Engine
This is Rietveld 408576698