net/http/http_proxy_client_socket_pool_unittest.cc - Issue 955553002: net: Remove static_cast of socket in HttpProxyClientSocketPoolTest.AsyncHaveAuth.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_proxy_client_socket_pool_unittest.cc

Issue 955553002: net: Remove static_cast of socket in HttpProxyClientSocketPoolTest.AsyncHaveAuth. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_proxy_client_socket_pool_unittest.cc

diff --git a/net/http/http_proxy_client_socket_pool_unittest.cc b/net/http/http_proxy_client_socket_pool_unittest.cc

index 62c50c024d26c805a5ce08f942aa0f808adbdc48..2f88b412d9dde614b48682cf4ce6251370acea95 100644

--- a/net/http/http_proxy_client_socket_pool_unittest.cc

+++ b/net/http/http_proxy_client_socket_pool_unittest.cc

@@ -526,8 +526,7 @@ TEST_P(HttpProxyClientSocketPoolTest, AsyncHaveAuth) {

EXPECT_EQ(OK, callback_.WaitForResult());

EXPECT_TRUE(handle_.is_initialized());

ASSERT_TRUE(handle_.socket());

- HttpProxyClientSocket* tunnel_socket =

- static_cast<HttpProxyClientSocket*>(handle_.socket());

+ StreamSocket* tunnel_socket = handle_.socket();

EXPECT_TRUE(tunnel_socket->IsConnected());

Ryan Hamilton 2015/02/24 05:39:30 You could also inline this to be handle_.socket()-

proxy_delegate->VerifyOnTunnelRequestCompleted(

"www.google.com:443",

« no previous file with comments | « no previous file | no next file » | no next file with comments »