Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 955553002: net: Remove static_cast of socket in HttpProxyClientSocketPoolTest.AsyncHaveAuth. (Closed)

Created:
5 years, 9 months ago by pcc1
Modified:
5 years, 9 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

net: Remove static_cast of socket in HttpProxyClientSocketPoolTest.AsyncHaveAuth. This socket is a SpdyProxyClientSocket. Fixes this test under -fsanitize=cfi-vptr. BUG=457523 TEST=net_unittests R=rch@chromium.org Committed: https://crrev.com/eb78e849da457747851532dce061b0c0be8c4155 Cr-Commit-Position: refs/heads/master@{#317758}

Patch Set 1 #

Total comments: 1

Patch Set 2 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M net/http/http_proxy_client_socket_pool_unittest.cc View 1 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
pcc1
5 years, 9 months ago (2015-02-24 05:27:11 UTC) #1
Ryan Hamilton
lgtm https://codereview.chromium.org/955553002/diff/1/net/http/http_proxy_client_socket_pool_unittest.cc File net/http/http_proxy_client_socket_pool_unittest.cc (right): https://codereview.chromium.org/955553002/diff/1/net/http/http_proxy_client_socket_pool_unittest.cc#newcode530 net/http/http_proxy_client_socket_pool_unittest.cc:530: EXPECT_TRUE(tunnel_socket->IsConnected()); You could also inline this to be ...
5 years, 9 months ago (2015-02-24 05:39:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/955553002/20001
5 years, 9 months ago (2015-02-24 05:48:29 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-02-24 06:07:38 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-02-24 06:08:23 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eb78e849da457747851532dce061b0c0be8c4155
Cr-Commit-Position: refs/heads/master@{#317758}

Powered by Google App Engine
This is Rietveld 408576698