Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1596)

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart

Issue 955543004: Pass SourceInformation through the CPS IR. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Update comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart
diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart
index e45762e17e6cc81c29a39a56869bd915c10d8273..3ff628083c965791f483d4be486927032ff15653 100644
--- a/pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart
+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart
@@ -10,6 +10,7 @@ import '../dart_types.dart';
import '../dart2jslib.dart';
import '../elements/elements.dart';
import '../io/source_file.dart';
+import '../io/source_information.dart';
import '../tree/tree.dart' as ast;
import '../scanner/scannerlib.dart' show Token, isUserDefinableOperator;
import '../universe/universe.dart' show SelectorKind;
@@ -390,10 +391,12 @@ abstract class IrBuilder {
ir.Primitive _buildInvokeStatic(Element element,
Selector selector,
- List<ir.Primitive> arguments) {
+ List<ir.Primitive> arguments,
+ SourceInformation sourceInformation) {
assert(isOpen);
return _continueWithExpression(
- (k) => new ir.InvokeStatic(element, selector, k, arguments));
+ (k) => new ir.InvokeStatic(element, selector, k, arguments,
+ sourceInformation));
}
ir.Primitive _buildInvokeSuper(Element target,
@@ -689,26 +692,32 @@ abstract class IrBuilder {
/// defined by [selector] and the argument values are defined by [arguments].
ir.Primitive buildStaticInvocation(Element element,
Selector selector,
- List<ir.Primitive> arguments) {
- return _buildInvokeStatic(element, selector, arguments);
+ List<ir.Primitive> arguments,
+ {SourceInformation sourceInformation}) {
+ return _buildInvokeStatic(element, selector, arguments, sourceInformation);
}
/// Create a static getter invocation of [element] where the getter name is
/// defined by [selector].
- ir.Primitive buildStaticGet(Element element, Selector selector) {
+ ir.Primitive buildStaticGet(Element element,
Johnni Winther 2015/02/24 08:29:30 The JS backend doesn't support static-get yet, so
+ Selector selector,
+ {SourceInformation sourceInformation}) {
assert(selector.isGetter);
// TODO(karlklose,sigurdm): build different nodes for getters.
- return _buildInvokeStatic(element, selector, const <ir.Primitive>[]);
+ return _buildInvokeStatic(
+ element, selector, const <ir.Primitive>[], sourceInformation);
}
/// Create a static setter invocation of [element] where the setter name and
/// argument are defined by [selector] and [value], respectively.
ir.Primitive buildStaticSet(Element element,
Selector selector,
- ir.Primitive value) {
+ ir.Primitive value,
+ {SourceInformation sourceInformation}) {
assert(selector.isSetter);
// TODO(karlklose,sigurdm): build different nodes for setters.
- _buildInvokeStatic(element, selector, <ir.Primitive>[value]);
+ _buildInvokeStatic(
+ element, selector, <ir.Primitive>[value], sourceInformation);
return value;
}

Powered by Google App Engine
This is Rietveld 408576698