Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 955523005: Add HostSharedBitmapManagerClient to organize bitmaps coming from renderers. (Closed)

Created:
5 years, 10 months ago by jbauman
Modified:
5 years, 9 months ago
Reviewers:
piman
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add HostSharedBitmapManagerClient to organize bitmaps coming from renderers. PeerHandle() is not necessarily unique, so have a HostSharedBitmapManagerClient per renderer channel that's responsible for deleting bitmaps from renderers that die. Committed: https://crrev.com/870d71597d1c249938627575f5d31a72992aff4d Cr-Commit-Position: refs/heads/master@{#319001}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -67 lines) Patch
M content/browser/renderer_host/render_message_filter.h View 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M content/common/host_shared_bitmap_manager.h View 3 chunks +33 lines, -9 lines 0 comments Download
M content/common/host_shared_bitmap_manager.cc View 4 chunks +36 lines, -25 lines 0 comments Download
M content/common/host_shared_bitmap_manager_unittest.cc View 7 chunks +21 lines, -19 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
jbauman
5 years, 10 months ago (2015-02-25 00:52:32 UTC) #2
piman
The linked bug suggests the issue is in the ChannelMojo.. Should we still do this?
5 years, 10 months ago (2015-02-25 01:47:40 UTC) #3
jbauman
On 2015/02/25 01:47:40, piman (Very slow to review) wrote: > The linked bug suggests the ...
5 years, 10 months ago (2015-02-25 01:49:32 UTC) #4
piman
LGTM anyway
5 years, 10 months ago (2015-02-25 01:50:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/955523005/1
5 years, 9 months ago (2015-03-04 01:02:08 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-04 02:17:50 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 02:18:29 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/870d71597d1c249938627575f5d31a72992aff4d
Cr-Commit-Position: refs/heads/master@{#319001}

Powered by Google App Engine
This is Rietveld 408576698