Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 955513009: Pull in gmock for standalone pdfium builds. (Closed)

Created:
5 years, 10 months ago by Tom Sepez
Modified:
5 years, 9 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Pull in gmock for standalone pdfium builds. For chromium checkouts, the top-level gmock is used instead. Verify build with a simple test that ensures neither mock method is fired. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/3d25502adc5ae37d1c3c74d367f16f770c465109

Patch Set 1 #

Patch Set 2 : First (empty) mock test. #

Total comments: 9

Patch Set 3 : Adress comments, add missing .cpp file. #

Patch Set 4 : Still can't alphebetize gtest vs. gmock. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -0 lines) Patch
M BUILD.gn View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
A fpdfsdk/src/fpdfformfill_embeddertest.cpp View 1 2 3 1 chunk +27 lines, -0 lines 0 comments Download
M pdfium.gyp View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M testing/embedder_test.cpp View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
A testing/embedder_test_mock_delegate.h View 1 1 chunk +19 lines, -0 lines 0 comments Download
A testing/gmock.gyp View 1 2 1 chunk +58 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Tom Sepez
Lei, for your consideration. Thanks.
5 years, 10 months ago (2015-02-26 01:04:38 UTC) #2
Lei Zhang
https://codereview.chromium.org/955513009/diff/20001/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/955513009/diff/20001/BUILD.gn#newcode834 BUILD.gn:834: "//testing/gmock", nit: gmock before gtest, ditto in pdfium.gyp https://codereview.chromium.org/955513009/diff/20001/testing/embedder_test.h ...
5 years, 10 months ago (2015-02-26 01:13:42 UTC) #3
Tom Sepez
Also note that the placeholder fpdfformfill_embeddertest.cpp file, referred to in the build files, is now ...
5 years, 9 months ago (2015-02-27 18:39:21 UTC) #4
Lei Zhang
lgtm
5 years, 9 months ago (2015-02-27 19:57:24 UTC) #5
Tom Sepez
5 years, 9 months ago (2015-02-27 20:56:30 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 (id:40002) manually as
3d25502adc5ae37d1c3c74d367f16f770c465109 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698