Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Issue 955513008: cleans up sdk patching so we no longer have unresolved names (Closed)

Created:
5 years, 10 months ago by Jennifer Messerly
Modified:
5 years, 10 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

cleans up sdk patching so we no longer have unresolved names js_codegen.dart and patch_sdk.dart are the only human-changed files. This also pulls in dart:isolate, which is depended on from one of the implementation libraries This also moves dart:_* files back to `lib/_internal/compiler/js_lib/` because there's where libraries.dart points to, and hence Analyzer looks for them there. Alternatively, we could put them somewhere like `tool/input_sdk_internal` and then copy that file into the right path. R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/d6195e020d36bbfb568a0a16ab62330ed5f57705

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10122 lines, -15054 lines) Patch
M lib/src/codegen/js_codegen.dart View 1 2 4 chunks +11 lines, -3 lines 0 comments Download
A test/codegen/expect/_foreign_helper/_foreign_helper.js View 1 2 1 chunk +156 lines, -0 lines 0 comments Download
A test/codegen/expect/_interceptors/_interceptors.js View 1 2 1 chunk +1401 lines, -0 lines 0 comments Download
M test/codegen/expect/_internal/_internal.js View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
A test/codegen/expect/_isolate_helper/_isolate_helper.js View 1 2 1 chunk +1247 lines, -0 lines 0 comments Download
A test/codegen/expect/_js_embedded_names/_js_embedded_names.js View 1 2 1 chunk +67 lines, -0 lines 0 comments Download
A test/codegen/expect/_js_helper/_js_helper.js View 1 2 1 chunk +3758 lines, -0 lines 0 comments Download
A test/codegen/expect/_js_names/_js_names.js View 1 2 1 chunk +70 lines, -0 lines 0 comments Download
A test/codegen/expect/_js_primitives/_js_primitives.js View 1 2 1 chunk +25 lines, -0 lines 0 comments Download
A test/codegen/expect/_native_typed_data/_native_typed_data.js View 1 2 1 chunk +1515 lines, -0 lines 0 comments Download
M test/codegen/expect/async/async.js View 1 2 4 chunks +20 lines, -20 lines 0 comments Download
M test/codegen/expect/collection/collection.js View 1 2 29 chunks +126 lines, -126 lines 0 comments Download
M test/codegen/expect/convert/convert.js View 1 2 7 chunks +22 lines, -22 lines 0 comments Download
M test/codegen/expect/core/core.js View 1 2 17 chunks +47 lines, -46 lines 0 comments Download
A test/codegen/expect/isolate/isolate.js View 1 2 1 chunk +208 lines, -0 lines 0 comments Download
M test/codegen/expect/math/math.js View 1 2 2 chunks +16 lines, -16 lines 0 comments Download
M test/codegen/expect/typed_data/typed_data.js View 1 2 16 chunks +37 lines, -37 lines 0 comments Download
A + test/generated_sdk/lib/_internal/compiler/js_lib/annotations.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/generated_sdk/lib/_internal/compiler/js_lib/constant_map.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/generated_sdk/lib/_internal/compiler/js_lib/foreign_helper.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/generated_sdk/lib/_internal/compiler/js_lib/interceptors.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/generated_sdk/lib/_internal/compiler/js_lib/isolate_helper.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/generated_sdk/lib/_internal/compiler/js_lib/isolate_serialization.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/generated_sdk/lib/_internal/compiler/js_lib/js_array.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/generated_sdk/lib/_internal/compiler/js_lib/js_helper.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/generated_sdk/lib/_internal/compiler/js_lib/js_mirrors.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/generated_sdk/lib/_internal/compiler/js_lib/js_names.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/generated_sdk/lib/_internal/compiler/js_lib/js_number.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/generated_sdk/lib/_internal/compiler/js_lib/js_primitives.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/generated_sdk/lib/_internal/compiler/js_lib/js_rti.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/generated_sdk/lib/_internal/compiler/js_lib/js_string.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/generated_sdk/lib/_internal/compiler/js_lib/mirror_helper.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/generated_sdk/lib/_internal/compiler/js_lib/native_helper.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/generated_sdk/lib/_internal/compiler/js_lib/native_typed_data.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/generated_sdk/lib/_internal/compiler/js_lib/regexp_helper.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/generated_sdk/lib/_internal/compiler/js_lib/shared/embedded_names.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/generated_sdk/lib/_internal/compiler/js_lib/string_helper.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M test/generated_sdk/lib/async/async.dart View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
M test/generated_sdk/lib/collection/collection.dart View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M test/generated_sdk/lib/convert/convert.dart View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M test/generated_sdk/lib/core/core.dart View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M test/generated_sdk/lib/internal/internal.dart View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A test/generated_sdk/lib/isolate/capability.dart View 1 2 1 chunk +34 lines, -0 lines 0 comments Download
A test/generated_sdk/lib/isolate/isolate.dart View 1 2 1 chunk +703 lines, -0 lines 0 comments Download
M test/generated_sdk/lib/math/math.dart View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M test/generated_sdk/lib/typed_data/typed_data.dart View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
D tool/input_sdk_patch/annotations.dart View 1 2 1 chunk +0 lines, -36 lines 0 comments Download
D tool/input_sdk_patch/constant_map.dart View 1 2 1 chunk +0 lines, -147 lines 0 comments Download
D tool/input_sdk_patch/foreign_helper.dart View 1 2 1 chunk +0 lines, -296 lines 0 comments Download
D tool/input_sdk_patch/interceptors.dart View 1 2 1 chunk +0 lines, -406 lines 0 comments Download
D tool/input_sdk_patch/isolate_helper.dart View 1 2 1 chunk +0 lines, -1454 lines 0 comments Download
D tool/input_sdk_patch/isolate_serialization.dart View 1 2 1 chunk +0 lines, -361 lines 0 comments Download
D tool/input_sdk_patch/js_array.dart View 1 2 1 chunk +0 lines, -389 lines 0 comments Download
D tool/input_sdk_patch/js_helper.dart View 1 2 1 chunk +0 lines, -3441 lines 0 comments Download
D tool/input_sdk_patch/js_mirrors.dart View 1 2 1 chunk +0 lines, -3034 lines 0 comments Download
D tool/input_sdk_patch/js_names.dart View 1 2 1 chunk +0 lines, -115 lines 0 comments Download
D tool/input_sdk_patch/js_number.dart View 1 2 1 chunk +0 lines, -422 lines 0 comments Download
D tool/input_sdk_patch/js_primitives.dart View 1 2 1 chunk +0 lines, -50 lines 0 comments Download
D tool/input_sdk_patch/js_rti.dart View 1 2 1 chunk +0 lines, -688 lines 0 comments Download
D tool/input_sdk_patch/js_string.dart View 1 2 1 chunk +0 lines, -471 lines 0 comments Download
D tool/input_sdk_patch/mirror_helper.dart View 1 2 1 chunk +0 lines, -25 lines 0 comments Download
D tool/input_sdk_patch/native_helper.dart View 1 2 1 chunk +0 lines, -652 lines 0 comments Download
D tool/input_sdk_patch/native_typed_data.dart View 1 2 1 chunk +0 lines, -2008 lines 0 comments Download
D tool/input_sdk_patch/preambles/README View 1 2 1 chunk +0 lines, -17 lines 0 comments Download
D tool/input_sdk_patch/preambles/d8.js View 1 2 1 chunk +0 lines, -283 lines 0 comments Download
D tool/input_sdk_patch/preambles/jsshell.js View 1 2 1 chunk +0 lines, -19 lines 0 comments Download
D tool/input_sdk_patch/regexp_helper.dart View 1 2 1 chunk +0 lines, -237 lines 0 comments Download
D tool/input_sdk_patch/shared/embedded_names.dart View 1 2 1 chunk +0 lines, -52 lines 0 comments Download
D tool/input_sdk_patch/string_helper.dart View 1 2 1 chunk +0 lines, -215 lines 0 comments Download
A + tool/input_sdk_src/lib/_internal/compiler/js_lib/annotations.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + tool/input_sdk_src/lib/_internal/compiler/js_lib/constant_map.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + tool/input_sdk_src/lib/_internal/compiler/js_lib/foreign_helper.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + tool/input_sdk_src/lib/_internal/compiler/js_lib/interceptors.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + tool/input_sdk_src/lib/_internal/compiler/js_lib/isolate_helper.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + tool/input_sdk_src/lib/_internal/compiler/js_lib/isolate_serialization.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + tool/input_sdk_src/lib/_internal/compiler/js_lib/js_array.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + tool/input_sdk_src/lib/_internal/compiler/js_lib/js_helper.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + tool/input_sdk_src/lib/_internal/compiler/js_lib/js_mirrors.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + tool/input_sdk_src/lib/_internal/compiler/js_lib/js_names.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + tool/input_sdk_src/lib/_internal/compiler/js_lib/js_number.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + tool/input_sdk_src/lib/_internal/compiler/js_lib/js_primitives.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + tool/input_sdk_src/lib/_internal/compiler/js_lib/js_rti.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + tool/input_sdk_src/lib/_internal/compiler/js_lib/js_string.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + tool/input_sdk_src/lib/_internal/compiler/js_lib/mirror_helper.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + tool/input_sdk_src/lib/_internal/compiler/js_lib/native_helper.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + tool/input_sdk_src/lib/_internal/compiler/js_lib/native_typed_data.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + tool/input_sdk_src/lib/_internal/compiler/js_lib/preambles/README View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + tool/input_sdk_src/lib/_internal/compiler/js_lib/preambles/d8.js View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + tool/input_sdk_src/lib/_internal/compiler/js_lib/preambles/jsshell.js View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + tool/input_sdk_src/lib/_internal/compiler/js_lib/regexp_helper.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + tool/input_sdk_src/lib/_internal/compiler/js_lib/shared/embedded_names.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + tool/input_sdk_src/lib/_internal/compiler/js_lib/string_helper.dart View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A tool/input_sdk_src/lib/isolate/capability.dart View 1 2 1 chunk +34 lines, -0 lines 0 comments Download
A tool/input_sdk_src/lib/isolate/isolate.dart View 1 2 1 chunk +618 lines, -0 lines 0 comments Download
M tool/patch_sdk.dart View 1 2 4 chunks +11 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jennifer Messerly
FYI: this builds on the previous 2 CL's related to tool/patch_sdk ... this is just ...
5 years, 10 months ago (2015-02-26 00:16:11 UTC) #2
vsm
lgtm
5 years, 10 months ago (2015-02-26 16:54:50 UTC) #3
Jennifer Messerly
5 years, 10 months ago (2015-02-27 01:58:19 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:20001) manually as
d6195e020d36bbfb568a0a16ab62330ed5f57705 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698