Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Issue 955493003: Revert of fix for linux builder warn on exit destructor (Closed)

Created:
5 years, 10 months ago by joshualitt
Modified:
5 years, 10 months ago
Reviewers:
joshua.litt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of fix for linux builder warn on exit destructor (patchset #1 id:1 of https://codereview.chromium.org/951103002/) Reason for revert: still breaks Original issue's description: > fix for linux builder warn on exit destructor > > TBR=bsalomon@google.com > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/51fdb4f8f63b6bb13e719000381e225503a2d4a0 TBR=joshualitt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/128def390017c5ad9e3ac79a25a3ef0e0ff2b658

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M include/gpu/GrClip.h View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
joshualitt
Created Revert of fix for linux builder warn on exit destructor
5 years, 10 months ago (2015-02-24 00:18:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/955493003/1
5 years, 10 months ago (2015-02-24 00:19:19 UTC) #2
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 00:19:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/128def390017c5ad9e3ac79a25a3ef0e0ff2b658

Powered by Google App Engine
This is Rietveld 408576698