Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 955473002: Move DeclarativeUserScriptManager/Master and UserScriptLoader to //extensions. (Closed)

Created:
5 years, 10 months ago by Xi Han
Modified:
5 years, 10 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, darin-cc_chromium.org, jam, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move DeclarativeUserScriptManager/Master and UserScriptLoader to //extensions. BUG=461052 Committed: https://crrev.com/3b2b3dfcf72c9216da672ff5c64433655443bce5 Cr-Commit-Position: refs/heads/master@{#317801}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -1194 lines) Patch
M chrome/browser/extensions/api/declarative_content/content_action.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_content/content_action.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/convert_user_script.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/extensions/declarative_user_script_manager.h View 1 chunk +0 lines, -59 lines 0 comments Download
D chrome/browser/extensions/declarative_user_script_manager.cc View 1 chunk +0 lines, -53 lines 0 comments Download
D chrome/browser/extensions/declarative_user_script_master.h View 1 chunk +0 lines, -53 lines 0 comments Download
D chrome/browser/extensions/declarative_user_script_master.cc View 1 chunk +0 lines, -40 lines 0 comments Download
M chrome/browser/extensions/extension_system_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
D chrome/browser/extensions/extension_user_script_loader.h View 1 chunk +0 lines, -59 lines 0 comments Download
D chrome/browser/extensions/extension_user_script_loader.cc View 1 chunk +0 lines, -166 lines 0 comments Download
M chrome/browser/extensions/extension_user_script_loader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/shared_user_script_master.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/test_extension_system.cc View 2 chunks +1 line, -1 line 0 comments Download
D chrome/browser/extensions/user_script_loader.h View 1 chunk +0 lines, -193 lines 0 comments Download
D chrome/browser/extensions/user_script_loader.cc View 1 chunk +0 lines, -492 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 4 chunks +1 line, -9 lines 0 comments Download
A + extensions/browser/declarative_user_script_manager.h View 5 chunks +9 lines, -6 lines 0 comments Download
A + extensions/browser/declarative_user_script_manager.cc View 2 chunks +8 lines, -7 lines 0 comments Download
A + extensions/browser/declarative_user_script_master.h View 3 chunks +9 lines, -6 lines 0 comments Download
A + extensions/browser/declarative_user_script_master.cc View 1 chunk +6 lines, -5 lines 0 comments Download
A + extensions/browser/extension_user_script_loader.h View 3 chunks +5 lines, -7 lines 0 comments Download
A + extensions/browser/extension_user_script_loader.cc View 5 chunks +16 lines, -12 lines 0 comments Download
A + extensions/browser/user_script_loader.h View 6 chunks +7 lines, -9 lines 0 comments Download
A + extensions/browser/user_script_loader.cc View 6 chunks +14 lines, -11 lines 0 comments Download
M extensions/extensions.gypi View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Xi Han
Hi yoz@: one simple CL which just mechanically moves several script injection related classes (browser ...
5 years, 10 months ago (2015-02-23 22:17:01 UTC) #3
Yoyo Zhou
LGTM
5 years, 10 months ago (2015-02-23 22:24:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/955473002/20001
5 years, 10 months ago (2015-02-24 14:32:35 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 10 months ago (2015-02-24 15:28:19 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 15:28:50 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3b2b3dfcf72c9216da672ff5c64433655443bce5
Cr-Commit-Position: refs/heads/master@{#317801}

Powered by Google App Engine
This is Rietveld 408576698