Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 955463002: Port chromium landmines script. (Closed)

Created:
5 years, 10 months ago by Michael Achenbach
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Port chromium landmines script. This runs the landmines script as a gclient hook. It can as such be used to clobber local checkouts when hooks are run locally. It is a softer version than chromium's landmines script, as it only deletes directories in the output directory due to compatibility with MSVS which has "build" hardcoded as output directory in several places. BUG=chromium:403263 LOG=n Committed: https://crrev.com/89731cfbf8ca6441594e9d64a0fa11a063d70800 Cr-Commit-Position: refs/heads/master@{#26831}

Patch Set 1 #

Patch Set 2 : #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -75 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
M DEPS View 1 chunk +11 lines, -0 lines 0 comments Download
A build/gyp_environment.py View 1 1 chunk +52 lines, -0 lines 0 comments Download
M build/gyp_v8 View 1 4 chunks +2 lines, -39 lines 0 comments Download
M build/landmine_utils.py View 1 1 chunk +9 lines, -0 lines 0 comments Download
M build/landmines.py View 1 5 chunks +117 lines, -36 lines 4 comments Download

Messages

Total messages: 9 (2 generated)
Michael Achenbach
PTAL. The landmines script is c/p from chromium's current landmines script. All differences are highlighted ...
5 years, 9 months ago (2015-02-24 15:30:27 UTC) #2
jochen (gone - plz use gerrit)
https://codereview.chromium.org/955463002/diff/20001/build/landmines.py File build/landmines.py (right): https://codereview.chromium.org/955463002/diff/20001/build/landmines.py#newcode163 build/landmines.py:163: if os.path.isdir(path) and re.search(r"(?:[Rr]elease)|(?:[Dd]ebug)", f): On 2015/02/24 at 15:30:27, ...
5 years, 9 months ago (2015-02-24 15:45:23 UTC) #3
Michael Achenbach
https://codereview.chromium.org/955463002/diff/20001/build/landmines.py File build/landmines.py (right): https://codereview.chromium.org/955463002/diff/20001/build/landmines.py#newcode163 build/landmines.py:163: if os.path.isdir(path) and re.search(r"(?:[Rr]elease)|(?:[Dd]ebug)", f): On 2015/02/24 15:45:22, jochen ...
5 years, 9 months ago (2015-02-24 16:29:32 UTC) #4
jochen (gone - plz use gerrit)
ok, lgtm
5 years, 9 months ago (2015-02-24 16:38:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/955463002/20001
5 years, 9 months ago (2015-02-24 16:41:12 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-02-24 16:57:45 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-02-24 16:57:57 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/89731cfbf8ca6441594e9d64a0fa11a063d70800
Cr-Commit-Position: refs/heads/master@{#26831}

Powered by Google App Engine
This is Rietveld 408576698