Source/core/html/track/TextTrackCueList.h - Issue 955443002: Replace open-coded binary search in TextTrackCueList::add with upper_bound

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/track/TextTrackCueList.h

Issue 955443002: Replace open-coded binary search in TextTrackCueList::add with upper_bound (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/track/TextTrackCueList.h

diff --git a/Source/core/html/track/TextTrackCueList.h b/Source/core/html/track/TextTrackCueList.h

index 3bdeea814894a0f8026983d3f0c9b6c38e5d0eec..9cc470383e7c593ab0a58274dc8110c667416e2e 100644

--- a/Source/core/html/track/TextTrackCueList.h

+++ b/Source/core/html/track/TextTrackCueList.h

@@ -59,7 +59,7 @@ public:

private:

TextTrackCueList();

- bool add(PassRefPtrWillBeRawPtr<TextTrackCue>, size_t, size_t);

+ size_t findInsertionIndex(const TextTrackCue*) const;

void clear();

void invalidateCueIndexes(size_t);