Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 955433002: Prototype objects never share their map, and hence cannot be in deprecated state. (Closed)

Created:
5 years, 10 months ago by Toon Verwaest
Modified:
5 years, 10 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Prototype objects never share their map, and hence cannot be in deprecated state. Committed: https://crrev.com/74c0cdbf762ff42f3d39c21329e468c451d7c564 Cr-Commit-Position: refs/heads/master@{#26802}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -30 lines) Patch
M src/ic/handler-compiler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 1 chunk +2 lines, -5 lines 0 comments Download
M src/objects.cc View 2 chunks +10 lines, -24 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Toon Verwaest
PTAL
5 years, 10 months ago (2015-02-23 17:31:21 UTC) #2
Igor Sheludko
lgtm with a nit: https://codereview.chromium.org/955433002/diff/1/src/objects.h File src/objects.h (right): https://codereview.chromium.org/955433002/diff/1/src/objects.h#newcode6071 src/objects.h:6071: // descriptor array of the ...
5 years, 10 months ago (2015-02-23 17:55:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/955433002/20001
5 years, 10 months ago (2015-02-23 18:03:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/955433002/20001
5 years, 10 months ago (2015-02-23 18:03:22 UTC) #7
commit-bot: I haz the power
Failed to commit the patch.
5 years, 10 months ago (2015-02-23 18:25:39 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-23 18:25:44 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 18:26:03 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/74c0cdbf762ff42f3d39c21329e468c451d7c564
Cr-Commit-Position: refs/heads/master@{#26802}

Powered by Google App Engine
This is Rietveld 408576698