Source/bindings/templates/attributes.cpp - Issue 955413002: Log in Binding code for invalid enum type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/templates/attributes.cpp

Issue 955413002: Log in Binding code for invalid enum type. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/webaudio/pannernode-basic-expected.txt ('K') | « LayoutTests/webaudio/pannernode-basic-expected.txt ('k') | Source/bindings/tests/results/core/V8TestInterface.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/templates/attributes.cpp

diff --git a/Source/bindings/templates/attributes.cpp b/Source/bindings/templates/attributes.cpp

index 0a627881244a3e6fd9919ff707f22e43ac7988d3..ac76aea37f79ac9d2a05d694145f308337f5a6db 100644

--- a/Source/bindings/templates/attributes.cpp

+++ b/Source/bindings/templates/attributes.cpp

@@ -262,8 +262,10 @@ v8::Local<v8::Value> v8Value, const v8::PropertyCallbackInfo<void>& info

{# Setter ignores invalid enum values:

http://www.w3.org/TR/WebIDL/#idl-enums #}

String string = cppValue;

- if (!({{attribute.enum_validation_expression}}))

+ if (!({{attribute.enum_validation_expression}})) {

+ currentExecutionContext(info.GetIsolate())->addConsoleMessage(ConsoleMessage::create(JSMessageSource, ErrorMessageLevel, "The provided value '" + string + "' is not a valid value of type '{{attribute.idl_type}}'."));

return;

+ }

{% endif %}

{# Pre-set context #}

{% if attribute.is_custom_element_callbacks or