LayoutTests/media/track/track-add-remove-cue-expected.txt - Issue 955413002: Log in Binding code for invalid enum type.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/media/track/track-add-remove-cue-expected.txt

Issue 955413002: Log in Binding code for invalid enum type. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/http/tests/inspector/console-xhr-logging-expected.txt ('K') | « LayoutTests/http/tests/media/media-source/mediasource-sourcebuffer-mode-expected.txt ('k') | LayoutTests/media/track/track-cue-mutable-expected.txt » ('j') | LayoutTests/media/track/track-cue-mutable-expected.txt » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	1 CONSOLE ERROR: The provided value '2' is not a valid value of type 'TextTrackMod e'.
	Nils Barth (inactive) 2015/02/26 17:21:54 Test bug: line 52 sets the mode to 2 newTrack.mode Test bug: line 52 sets the mode to 2 newTrack.mode = 2; It should have the enum value: run("newTrack.mode = 'showing'"); https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit... Could you fix this FIRST in a separate CL to eliminate this noise? Thanks! Could you also add a check to track-mode.html that setting a numeric value '2' doesn't work? Something like this: consoleWrite("<b>*** Set to numeric value (no longer supported), should return default</b>"); var value = "2"; run("textTrack.mode = " + value); testExpected("textTrack.mode", "showing"); testExpected("video.textTracks[0].mode", "showing"); consoleWrite(""); https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
1 Tests TextTrack's addCue and removeCue	2 Tests TextTrack's addCue and removeCue

2	3

3	4

4 *** Test cues loaded from the file.	5 *** Test cues loaded from the file.

5 EXPECTED (cues.length == '4') OK	6 EXPECTED (cues.length == '4') OK

6 EXPECTED (cues.getCueById('1').startTime == '0') OK	7 EXPECTED (cues.getCueById('1').startTime == '0') OK

7 EXPECTED (cues[1].startTime == '31') OK	8 EXPECTED (cues[1].startTime == '31') OK

8 EXPECTED (cues[2].startTime == '61') OK	9 EXPECTED (cues[2].startTime == '61') OK

9 EXPECTED (cues.getCueById('4').startTime == '121') OK	10 EXPECTED (cues.getCueById('4').startTime == '121') OK

10 EXPECTED (cues.getCueById('junk') == 'undefined') OK	11 EXPECTED (cues.getCueById('junk') == 'undefined') OK

(...skipping 66 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
77	78

78 *** Add a cue before all the existing cues.	79 *** Add a cue before all the existing cues.

79 RUN(testTrack.track.addCue(new VTTCue(0, 31, 'I am first')))	80 RUN(testTrack.track.addCue(new VTTCue(0, 31, 'I am first')))

80 EXPECTED (cues[0].startTime == '0') OK	81 EXPECTED (cues[0].startTime == '0') OK

81 EXPECTED (cues[0].endTime == '31') OK	82 EXPECTED (cues[0].endTime == '31') OK

82 EXPECTED (cues[1].startTime == '0') OK	83 EXPECTED (cues[1].startTime == '0') OK

83 EXPECTED (cues[1].endTime == '30.5') OK	84 EXPECTED (cues[1].endTime == '30.5') OK

84 EXPECTED (cues[2].startTime == '31') OK	85 EXPECTED (cues[2].startTime == '31') OK

85 END OF TEST	86 END OF TEST

86	87

OLD	NEW