Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
955393002:
ensure host compiler is always clang when cross compiling from linux (Closed)
|
Created:
5 years, 10 months ago by dcarney Modified:
5 years, 9 months ago Reviewers:
Michael Achenbach CC:
v8-dev Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Descriptionensure host compiler is always clang when cross compiling from linux
BUG=
Committed: https://crrev.com/56039af476797accc238dcb24c7ab926899287a0
Cr-Commit-Position: refs/heads/master@{#26881}
Committed: https://crrev.com/99edffd9a4d2fdef324bd6244129279dc3ea8d21
Cr-Commit-Position: refs/heads/master@{#26915}
Patch Set 1 #Patch Set 2 : #Patch Set 3 : #Patch Set 4 : #
Total comments: 1
Patch Set 5 : #Patch Set 6 : #Patch Set 7 : #Messages
Total messages: 24 (10 generated)
machenbach@chromium.org changed reviewers: + machenbach@chromium.org
lgtm
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/955393002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/3245)
https://codereview.chromium.org/955393002/diff/60001/build/standalone.gypi File build/standalone.gypi (right): https://codereview.chromium.org/955393002/diff/60001/build/standalone.gypi#ne... build/standalone.gypi:340: ['CC.host', '<(clang_dir)/bin/clang'], I don't think this should be set when clang=0
https://codereview.chromium.org/955393002/diff/60001/build/standalone.gypi File build/standalone.gypi (right): https://codereview.chromium.org/955393002/diff/60001/build/standalone.gypi#ne... build/standalone.gypi:340: ['CC.host', '<(clang_dir)/bin/clang'], I don't think this should be set when clang=0
The CQ bit was checked by dcarney@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from machenbach@chromium.org Link to the patchset: https://codereview.chromium.org/955393002/#ps80001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/955393002/80001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/3253)
The CQ bit was checked by dcarney@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from machenbach@chromium.org Link to the patchset: https://codereview.chromium.org/955393002/#ps100001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/955393002/100001
Message was sent while issue was closed.
Committed patchset #6 (id:100001)
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/56039af476797accc238dcb24c7ab926899287a0 Cr-Commit-Position: refs/heads/master@{#26881}
Message was sent while issue was closed.
A revert of this CL (patchset #6 id:100001) has been created in https://codereview.chromium.org/964483002/ by dcarney@chromium.org. The reason for reverting is: broke some things.
The CQ bit was checked by dcarney@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from machenbach@chromium.org Link to the patchset: https://codereview.chromium.org/955393002/#ps120001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/955393002/120001
Message was sent while issue was closed.
Committed patchset #7 (id:120001)
Message was sent while issue was closed.
Patchset 7 (id:??) landed as https://crrev.com/99edffd9a4d2fdef324bd6244129279dc3ea8d21 Cr-Commit-Position: refs/heads/master@{#26915} |
