content/browser/permissions/permission_service_impl.h - Issue 955383003: ContentBrowserClient::RequestPermission replies with PermissionStatus instead of bool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/permissions/permission_service_impl.h

Issue 955383003: ContentBrowserClient::RequestPermission replies with PermissionStatus instead of bool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix android geolocation breakage Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/content_settings/permission_context_base.cc ('K') | « content/browser/media/cdm/browser_cdm_manager.cc ('k') | content/browser/permissions/permission_service_impl.cc » ('j') | content/public/browser/content_browser_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/permissions/permission_service_impl.h

diff --git a/content/browser/permissions/permission_service_impl.h b/content/browser/permissions/permission_service_impl.h

index afbb8d76f34d33e9de70d48d94db5287bcdc7ed7..57f1bfd48b1fa166b0c40c4261c6ec844ab6a4cf 100644

--- a/content/browser/permissions/permission_service_impl.h

+++ b/content/browser/permissions/permission_service_impl.h

@@ -63,7 +63,7 @@ class PermissionServiceImpl : public mojo::InterfaceImpl<PermissionService> {

void OnRequestPermissionResponse(

const mojo::Callback<void(PermissionStatus)>& callback,

int request_id,

- bool allowed);

+ PermissionStatus status);

PermissionStatus GetPermissionStatus(PermissionType type, GURL origin);

void ResetPermissionStatus(PermissionType type, GURL origin);