chrome/browser/services/gcm/push_messaging_permission_context.h - Issue 955383003: ContentBrowserClient::RequestPermission replies with PermissionStatus instead of bool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/services/gcm/push_messaging_permission_context.h

Issue 955383003: ContentBrowserClient::RequestPermission replies with PermissionStatus instead of bool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix android geolocation breakage Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/content_settings/permission_context_base.cc ('K') | « chrome/browser/notifications/desktop_notification_service.cc ('k') | chrome/browser/services/gcm/push_messaging_permission_context.cc » ('j') | content/public/browser/content_browser_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/services/gcm/push_messaging_permission_context.h

diff --git a/chrome/browser/services/gcm/push_messaging_permission_context.h b/chrome/browser/services/gcm/push_messaging_permission_context.h

index 0b4a49fb4f684d89a4d600c3d2e3a34fc050307c..5f9a5a0ddeaf327e5c92ecb28bd9751530b78555 100644

--- a/chrome/browser/services/gcm/push_messaging_permission_context.h

+++ b/chrome/browser/services/gcm/push_messaging_permission_context.h

@@ -47,7 +47,7 @@ class PushMessagingPermissionContext : public PermissionContextBase {

const GURL& requesting_origin,

const GURL& embedding_origin,

const BrowserPermissionCallback& callback,

- bool notifications_permission_granted);

+ ContentSetting notifications_content_setting);

Profile* profile_;