chrome/browser/notifications/desktop_notification_service.h - Issue 955383003: ContentBrowserClient::RequestPermission replies with PermissionStatus instead of bool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/desktop_notification_service.h

Issue 955383003: ContentBrowserClient::RequestPermission replies with PermissionStatus instead of bool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix android geolocation breakage Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/content_settings/permission_context_base.cc ('K') | « chrome/browser/media/protected_media_identifier_permission_context.cc ('k') | chrome/browser/notifications/desktop_notification_service.cc » ('j') | content/public/browser/content_browser_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/desktop_notification_service.h

diff --git a/chrome/browser/notifications/desktop_notification_service.h b/chrome/browser/notifications/desktop_notification_service.h

index 0c7407fb5db41d6b3090608f2117b3f3c4354794..8f1e167c2b3f8870ecfddd560bd7e93986a5fd4a 100644

--- a/chrome/browser/notifications/desktop_notification_service.h

+++ b/chrome/browser/notifications/desktop_notification_service.h

@@ -61,7 +61,7 @@ class DesktopNotificationService : public PermissionContextBase

const PermissionRequestID& request_id,

const GURL& requesting_origin,

bool user_gesture,

- const base::Callback<void(bool)>& result_callback);

+ const BrowserPermissionCallback& result_callback);

// Returns true if the notifier with |notifier_id| is allowed to send

// notifications.

@@ -93,7 +93,7 @@ class DesktopNotificationService : public PermissionContextBase

// PermissionContextBase:

void UpdateContentSetting(const GURL& requesting_origin,

const GURL& embedder_origin,

- bool allowed) override;

+ ContentSetting content_setting) override;

// The profile which owns this object.

Profile* profile_;