chrome/browser/geolocation/geolocation_permission_context_extensions.h - Issue 955383003: ContentBrowserClient::RequestPermission replies with PermissionStatus instead of bool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/geolocation/geolocation_permission_context_extensions.h

Issue 955383003: ContentBrowserClient::RequestPermission replies with PermissionStatus instead of bool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix android geolocation breakage Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/content_settings/permission_context_base.cc ('K') | « chrome/browser/geolocation/geolocation_permission_context_android.cc ('k') | chrome/browser/geolocation/geolocation_permission_context_extensions.cc » ('j') | content/public/browser/content_browser_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/geolocation/geolocation_permission_context_extensions.h

diff --git a/chrome/browser/geolocation/geolocation_permission_context_extensions.h b/chrome/browser/geolocation/geolocation_permission_context_extensions.h

index e073b14f5d83bfc562e52d57fbd825392e026185..a7bcaf97a9e657436e02643bd8b12d8f065543d9 100644

--- a/chrome/browser/geolocation/geolocation_permission_context_extensions.h

+++ b/chrome/browser/geolocation/geolocation_permission_context_extensions.h

@@ -7,6 +7,7 @@

#include "base/callback_forward.h"

#include "base/macros.h"

+#include "components/content_settings/core/common/content_settings.h"

namespace content {

class WebContents;

@@ -30,7 +31,7 @@ class GeolocationPermissionContextExtensions {

int bridge_id,

const GURL& requesting_frame,

bool user_gesture,

- base::Callback<void(bool)> callback,

+ const base::Callback<void(ContentSetting)>& callback,

bool* permission_set,

bool* new_permission);