Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1174)

Unified Diff: chrome/browser/content_settings/permission_queue_controller_unittest.cc

Issue 955383003: ContentBrowserClient::RequestPermission replies with PermissionStatus instead of bool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix android geolocation breakage Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/content_settings/permission_queue_controller_unittest.cc
diff --git a/chrome/browser/content_settings/permission_queue_controller_unittest.cc b/chrome/browser/content_settings/permission_queue_controller_unittest.cc
index d21cd9b2f765d6a39ee01b6fa853c2e0813309e4..4cc3eac8b2ab4d805a6e357b478f9749a4501185 100644
--- a/chrome/browser/content_settings/permission_queue_controller_unittest.cc
+++ b/chrome/browser/content_settings/permission_queue_controller_unittest.cc
@@ -95,21 +95,21 @@ TEST_F(PermissionQueueControllerTests, OneObservationPerInfoBarCancelled) {
// for notifications, it gets notified exactly once."
ObservationCountingQueueController queue_controller(profile());
GURL url("http://www.example.com/geolocation");
- base::Callback<void(bool)> callback;
+ base::Callback<void(ContentSetting)> callback;
queue_controller.CreateInfoBarRequest(
RequestID(0), url, url, callback);
queue_controller.CreateInfoBarRequest(
RequestID(1), url, url, callback);
queue_controller.CancelInfoBarRequest(RequestID(0));
EXPECT_EQ(1, queue_controller.call_count());
-};
+}
TEST_F(PermissionQueueControllerTests, FailOnBadPattern) {
ObservationCountingQueueController queue_controller(profile());
GURL url("chrome://settings");
- base::Callback<void(bool)> callback;
+ base::Callback<void(ContentSetting)> callback;
queue_controller.CreateInfoBarRequest(
RequestID(0), url, url, callback);
queue_controller.CancelInfoBarRequest(RequestID(0));
EXPECT_EQ(0, queue_controller.call_count());
-};
+}

Powered by Google App Engine
This is Rietveld 408576698