android_webview/browser/aw_content_browser_client.h - Issue 955383003: ContentBrowserClient::RequestPermission replies with PermissionStatus instead of bool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/aw_content_browser_client.h

Issue 955383003: ContentBrowserClient::RequestPermission replies with PermissionStatus instead of bool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix android geolocation breakage Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/browser/aw_content_browser_client.h

diff --git a/android_webview/browser/aw_content_browser_client.h b/android_webview/browser/aw_content_browser_client.h

index e5d874974761643746cc9ad1c50805938f8f42d1..cae1bf3d0b634473df9b3b4eeaab8c10b32f29d6 100644

--- a/android_webview/browser/aw_content_browser_client.h

+++ b/android_webview/browser/aw_content_browser_client.h

@@ -112,7 +112,7 @@ class AwContentBrowserClient : public content::ContentBrowserClient {

int bridge_id,

const GURL& requesting_frame,

bool user_gesture,

- const base::Callback<void(bool)>& result_callback) override;

+ const base::Callback<void(content::PermissionStatus)>& callback) override;

void CancelPermissionRequest(content::PermissionType permission,

content::WebContents* web_contents,

int bridge_id,

« no previous file with comments | « no previous file | android_webview/browser/aw_content_browser_client.cc » ('j') | chrome/browser/content_settings/permission_context_base.cc » ('J')