ContentBrowserClient::RequestPermission replies with PermissionStatus instead of bool.

content/public/browser/content_browser_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/browser/content_browser_client.h"
 
 #include "base/files/file_path.h"
 #include "ui/gfx/image/image_skia.h"
 #include "url/gurl.h"
 
@@ skipping 212 matching lines @@
 ContentBrowserClient::GetPlatformNotificationService() {
   return nullptr;
 }
 
 void ContentBrowserClient::RequestPermission(
     PermissionType permission,
     WebContents* web_contents,
     int bridge_id,
     const GURL& requesting_frame,
     bool user_gesture,
-    const base::Callback<void(bool)>& result_callback) {
-  result_callback.Run(true);
+    const base::Callback<void(PermissionStatus)>& callback) {
+  callback.Run(PERMISSION_STATUS_DENIED);

[gunsch, 2015/03/26 22:36:55]

I'm a little late to the party, but I just noticed that among the changes in
this CL it changed the behavior of all content embedders from defaulting to
returning "true" when permissions were requested to "denied". I wasn't able to
find a discussion about this change on the thread or the linked bug. What was
the reasoning here?

[mlamouri (slow - plz ping), 2015/03/30 09:32:41]

If you look at ContentBrowserClient, this is how it behave: everything usually
fails as a default implementation.

FWIW, the permission management has been moved out of ContentBrowserClient (to
content::PermissionManager) so hopefully, content embedders will catch that
change in default behaviour.

 }
 
 PermissionStatus ContentBrowserClient::GetPermissionStatus(
     PermissionType permission,
     BrowserContext* browser_context,
     const GURL& requesting_origin,
     const GURL& embedding_origin) {
   return PERMISSION_STATUS_DENIED;
 }
 
@@ skipping 116 matching lines @@
 
 #if defined(VIDEO_HOLE)
 ExternalVideoSurfaceContainer*
 ContentBrowserClient::OverrideCreateExternalVideoSurfaceContainer(
     WebContents* web_contents) {
   return nullptr;
 }
 #endif
 
 }  // namespace content