Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Side by Side Diff: chrome/browser/services/gcm/push_messaging_permission_context.cc

Issue 955383003: ContentBrowserClient::RequestPermission replies with PermissionStatus instead of bool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix android geolocation breakage Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/services/gcm/push_messaging_permission_context.h" 5 #include "chrome/browser/services/gcm/push_messaging_permission_context.h"
6 6
7 #include "chrome/browser/content_settings/permission_context_uma_util.h" 7 #include "chrome/browser/content_settings/permission_context_uma_util.h"
8 #include "chrome/browser/notifications/desktop_notification_service.h" 8 #include "chrome/browser/notifications/desktop_notification_service.h"
9 #include "chrome/browser/notifications/desktop_notification_service_factory.h" 9 #include "chrome/browser/notifications/desktop_notification_service_factory.h"
10 #include "chrome/browser/profiles/profile.h" 10 #include "chrome/browser/profiles/profile.h"
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 content::WebContents* web_contents, 79 content::WebContents* web_contents,
80 const PermissionRequestID& id, 80 const PermissionRequestID& id,
81 const GURL& requesting_origin, 81 const GURL& requesting_origin,
82 const GURL& embedding_origin, 82 const GURL& embedding_origin,
83 bool user_gesture, 83 bool user_gesture,
84 const BrowserPermissionCallback& callback) { 84 const BrowserPermissionCallback& callback) {
85 DCHECK_CURRENTLY_ON(content::BrowserThread::UI); 85 DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
86 #if defined(ENABLE_NOTIFICATIONS) 86 #if defined(ENABLE_NOTIFICATIONS)
87 if (requesting_origin != embedding_origin) { 87 if (requesting_origin != embedding_origin) {
88 NotifyPermissionSet(id, requesting_origin, embedding_origin, callback, 88 NotifyPermissionSet(id, requesting_origin, embedding_origin, callback,
89 false /* persist */, false /* granted */); 89 false /* persist */, CONTENT_SETTING_BLOCK);
90 return; 90 return;
91 } 91 }
92 DesktopNotificationService* notification_service = 92 DesktopNotificationService* notification_service =
93 DesktopNotificationServiceFactory::GetForProfile(profile_); 93 DesktopNotificationServiceFactory::GetForProfile(profile_);
94 DCHECK(notification_service); 94 DCHECK(notification_service);
95 95
96 notification_service->RequestPermission( 96 notification_service->RequestPermission(
97 web_contents, id, requesting_origin, user_gesture, 97 web_contents, id, requesting_origin, user_gesture,
98 base::Bind(&PushMessagingPermissionContext::DecidePushPermission, 98 base::Bind(&PushMessagingPermissionContext::DecidePushPermission,
99 weak_factory_ui_thread_.GetWeakPtr(), id, requesting_origin, 99 weak_factory_ui_thread_.GetWeakPtr(), id, requesting_origin,
100 embedding_origin, callback)); 100 embedding_origin, callback));
101 #else 101 #else
102 NotifyPermissionSet(id, requesting_origin, embedding_origin, callback, 102 NotifyPermissionSet(id, requesting_origin, embedding_origin, callback,
103 false /* persist */, false /* granted */); 103 false /* persist */, CONTENT_SETTING_BLOCK);
104 #endif 104 #endif
105 } 105 }
106 106
107 void PushMessagingPermissionContext::DecidePushPermission( 107 void PushMessagingPermissionContext::DecidePushPermission(
108 const PermissionRequestID& id, 108 const PermissionRequestID& id,
109 const GURL& requesting_origin, 109 const GURL& requesting_origin,
110 const GURL& embedding_origin, 110 const GURL& embedding_origin,
111 const BrowserPermissionCallback& callback, 111 const BrowserPermissionCallback& callback,
112 bool notifications_permission_granted) { 112 ContentSetting notification_content_setting) {
113 DCHECK_CURRENTLY_ON(content::BrowserThread::UI); 113 DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
114 ContentSetting push_content_setting = 114 ContentSetting push_content_setting =
115 profile_->GetHostContentSettingsMap() 115 profile_->GetHostContentSettingsMap()
116 ->GetContentSettingAndMaybeUpdateLastUsage( 116 ->GetContentSettingAndMaybeUpdateLastUsage(
117 requesting_origin, embedding_origin, kPushSettingType, 117 requesting_origin, embedding_origin, kPushSettingType,
118 std::string()); 118 std::string());
119 119
120 if (push_content_setting == CONTENT_SETTING_BLOCK) { 120 if (push_content_setting == CONTENT_SETTING_BLOCK) {
121 DVLOG(1) << "Push permission was explicitly blocked."; 121 DVLOG(1) << "Push permission was explicitly blocked.";
122 PermissionContextUmaUtil::PermissionDenied(kPushSettingType, 122 PermissionContextUmaUtil::PermissionDenied(kPushSettingType,
123 requesting_origin); 123 requesting_origin);
124 NotifyPermissionSet(id, requesting_origin, embedding_origin, callback, 124 NotifyPermissionSet(id, requesting_origin, embedding_origin, callback,
125 true /* persist */, false /* granted */); 125 true /* persist */, CONTENT_SETTING_BLOCK);
126 return; 126 return;
127 } 127 }
128 128
129 if (!notifications_permission_granted) { 129 if (notification_content_setting != CONTENT_SETTING_ALLOW) {
130 DVLOG(1) << "Notification permission has not been granted."; 130 DVLOG(1) << "Notification permission has not been granted.";
131 NotifyPermissionSet(id, requesting_origin, embedding_origin, callback, 131 NotifyPermissionSet(id, requesting_origin, embedding_origin, callback,
132 false /* persist */, false /* granted */); 132 false /* persist */, notification_content_setting);
133 return; 133 return;
134 } 134 }
135 135
136 PermissionContextUmaUtil::PermissionGranted(kPushSettingType, 136 PermissionContextUmaUtil::PermissionGranted(kPushSettingType,
137 requesting_origin); 137 requesting_origin);
138 NotifyPermissionSet(id, requesting_origin, embedding_origin, callback, 138 NotifyPermissionSet(id, requesting_origin, embedding_origin, callback,
139 true /* persist */, true /* granted */); 139 true /* persist */, CONTENT_SETTING_ALLOW);
140 } 140 }
141 } // namespace gcm 141 } // namespace gcm
142 142
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698