remoting/webapp/unittests/xmpp_connection_unittest.js - Issue 955283002: Converted remoting.Error from an enum to a class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/webapp/unittests/xmpp_connection_unittest.js

Issue 955283002: Converted remoting.Error from an enum to a class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Requested changes. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/webapp/unittests/xmpp_connection_unittest.js

diff --git a/remoting/webapp/unittests/xmpp_connection_unittest.js b/remoting/webapp/unittests/xmpp_connection_unittest.js

index a36261f9fba4059d3ae0f1d14d9846225fd52f70..8d133887011e178033e79dadeed990f9072512a8 100644

--- a/remoting/webapp/unittests/xmpp_connection_unittest.js

+++ b/remoting/webapp/unittests/xmpp_connection_unittest.js

@@ -56,7 +56,7 @@ test('should go to FAILED state when failed to connect', function() {

chrome.socket.connect, socketId, "xmpp.example.com", 123);

chrome.socket.connect.getCall(0).args[3](-1);

- QUnit.equal(connection.getError(), remoting.Error.NETWORK_FAILURE);

+ QUnit.equal(connection.getError().tag, remoting.Error.Tag.NETWORK_FAILURE);

});

test('should use XmppLoginHandler to complete handshake and read data',