remoting/webapp/crd/js/xmpp_login_handler.js - Issue 955283002: Converted remoting.Error from an enum to a class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/webapp/crd/js/xmpp_login_handler.js

Issue 955283002: Converted remoting.Error from an enum to a class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Requested changes. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/webapp/crd/js/xmpp_login_handler.js

diff --git a/remoting/webapp/crd/js/xmpp_login_handler.js b/remoting/webapp/crd/js/xmpp_login_handler.js

index 74be464997962c2e60a4423501e0d8c88d4c80b3..aa9df2269ba13db100611b1204ec1add231deedd 100644

--- a/remoting/webapp/crd/js/xmpp_login_handler.js

+++ b/remoting/webapp/crd/js/xmpp_login_handler.js

@@ -27,7 +27,7 @@ var remoting = remoting || {};

* @param {function(string, remoting.XmppStreamParser):void}

* onHandshakeDoneCallback Callback to call after authentication is

* completed successfully

- * @param {function(remoting.Error, string):void} onErrorCallback Callback to

+ * @param {function(!remoting.Error, string):void} onErrorCallback Callback to

* call on error. Can be called at any point during lifetime of connection.

* @constructor

@@ -275,7 +275,7 @@ remoting.XmppLoginHandler.prototype.startStream_ = function(firstMessage) {

}

/**

- * @param {remoting.Error} error

+ * @param {!remoting.Error} error

* @param {string} text

* @private