Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Unified Diff: remoting/webapp/crd/js/wcs_loader.js

Issue 955283002: Converted remoting.Error from an enum to a class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Requested changes. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/crd/js/wcs_loader.js
diff --git a/remoting/webapp/crd/js/wcs_loader.js b/remoting/webapp/crd/js/wcs_loader.js
index 3ab10bffae86b474e85d630ec793dfee59e99cb2..06f01e5d5ce6a2f21943440c3be183ab42399ce7 100644
--- a/remoting/webapp/crd/js/wcs_loader.js
+++ b/remoting/webapp/crd/js/wcs_loader.js
@@ -46,7 +46,7 @@ remoting.WcsLoader.prototype.SCRIPT_NODE_ID_ = 'wcs-script-node';
* @param {string} token An OAuth2 access token.
* @param {function(string): void} onReady The callback function, called with
* a client JID when WCS has been loaded.
- * @param {function(remoting.Error):void} onError Function to invoke with an
+ * @param {function(!remoting.Error):void} onError Function to invoke with an
* error code on failure.
* @return {void} Nothing.
*/
@@ -73,7 +73,7 @@ remoting.WcsLoader.prototype.start = function(token, onReady, onError) {
var onLoadError = function(event) {
// The DOM Event object has no detail on the nature of the error, so try to
// validate the token to get a better idea.
- /** @param {remoting.Error} error Error code. */
+ /** @param {!remoting.Error} error Error code. */
var onValidateError = function(error) {
var typedNode = /** @type {Element} */ (node);
typedNode.parentNode.removeChild(node);
@@ -111,7 +111,7 @@ remoting.WcsLoader.prototype.constructWcs_ = function(token, onReady) {
*
* @param {string} token The access token.
* @param {function():void} onOk Callback to invoke if the token is valid.
- * @param {function(remoting.Error):void} onError Function to invoke with an
+ * @param {function(!remoting.Error):void} onError Function to invoke with an
* error code on failure.
* @return {void} Nothing.
*/

Powered by Google App Engine
This is Rietveld 408576698