Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Unified Diff: remoting/webapp/crd/js/remoting.js

Issue 955283002: Converted remoting.Error from an enum to a class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Requested changes. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/crd/js/remoting.js
diff --git a/remoting/webapp/crd/js/remoting.js b/remoting/webapp/crd/js/remoting.js
index bc23d7ce367509de612a192092329144717c93cb..416455046f3f9ad1ce28444e82e27f3095a9feb7 100644
--- a/remoting/webapp/crd/js/remoting.js
+++ b/remoting/webapp/crd/js/remoting.js
@@ -174,14 +174,14 @@ remoting.timestamp = function() {
* Show an error message, optionally including a short-cut for signing in to
* Chromoting again.
*
- * @param {remoting.Error} error
+ * @param {!remoting.Error} error
* @return {void} Nothing.
*/
remoting.showErrorMessage = function(error) {
l10n.localizeElementFromTag(
document.getElementById('token-refresh-error-message'),
- error);
- var auth_failed = (error == remoting.Error.AUTHENTICATION_FAILED);
+ error.tag);
+ var auth_failed = (error.tag == remoting.Error.Tag.AUTHENTICATION_FAILED);
if (base.isAppsV2()) {
remoting.handleAuthFailureAndRelaunch();
} else {

Powered by Google App Engine
This is Rietveld 408576698