Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(898)

Unified Diff: remoting/webapp/crd/js/host_daemon_facade.js

Issue 955283002: Converted remoting.Error from an enum to a class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Requested changes. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/crd/js/host_daemon_facade.js
diff --git a/remoting/webapp/crd/js/host_daemon_facade.js b/remoting/webapp/crd/js/host_daemon_facade.js
index 193a7562a609a18097f2e2a5e0d8d962592627dd..330da4c9da548a1b0e233ec47c915b3dd69df226 100644
--- a/remoting/webapp/crd/js/host_daemon_facade.js
+++ b/remoting/webapp/crd/js/host_daemon_facade.js
@@ -48,7 +48,7 @@ remoting.HostDaemonFacade = function() {
*/
this.initializingPromise_ = null;
- /** @type {remoting.Error} @private */
+ /** @type {!remoting.Error} @private */
this.error_ = remoting.Error.NONE;
/** @private */
@@ -118,7 +118,7 @@ remoting.HostDaemonFacade.prototype.connectNative_ = function() {
* @param {string} type Type of the originating request.
* @param {function(...):void} onDone Response callback. Parameters depend on
* the request type.
- * @param {function(remoting.Error):void} onError Callback to call on error.
+ * @param {function(!remoting.Error):void} onError Callback to call on error.
* @constructor
*/
remoting.HostDaemonFacade.PendingReply = function(type, onDone, onError) {
@@ -148,7 +148,7 @@ remoting.HostDaemonFacade.prototype.hasFeature = function(feature, onDone) {
* @param {{type: string}} message The message to post.
* @param {function(...):void} onDone The callback, if any, to be triggered
* on response.
- * @param {function(remoting.Error):void} onError Callback to call on error.
+ * @param {function(!remoting.Error):void} onError Callback to call on error.
* @private
*/
remoting.HostDaemonFacade.prototype.postMessage_ =
@@ -171,7 +171,7 @@ remoting.HostDaemonFacade.prototype.postMessage_ =
* @param {{type: string}} message The message to post.
* @param {function(...):void} onDone The callback, if any, to be triggered
* on response.
- * @param {function(remoting.Error):void} onError Callback to call on error.
+ * @param {function(!remoting.Error):void} onError Callback to call on error.
* @return {void} Nothing.
* @private
*/
@@ -347,7 +347,7 @@ remoting.HostDaemonFacade.prototype.onDisconnect_ = function() {
* Gets local hostname.
*
* @param {function(string):void} onDone Callback to return result.
- * @param {function(remoting.Error):void} onError Callback to call on error.
+ * @param {function(!remoting.Error):void} onError Callback to call on error.
* @return {void} Nothing.
*/
remoting.HostDaemonFacade.prototype.getHostName =
@@ -362,7 +362,7 @@ remoting.HostDaemonFacade.prototype.getHostName =
* @param {string} hostId The host ID.
* @param {string} pin The PIN.
* @param {function(string):void} onDone Callback to return result.
- * @param {function(remoting.Error):void} onError Callback to call on error.
+ * @param {function(!remoting.Error):void} onError Callback to call on error.
* @return {void} Nothing.
*/
remoting.HostDaemonFacade.prototype.getPinHash =
@@ -380,7 +380,7 @@ remoting.HostDaemonFacade.prototype.getPinHash =
* host (PublicKeyInfo structure encoded with ASN.1 DER, and then BASE64).
*
* @param {function(string, string):void} onDone Callback to return result.
- * @param {function(remoting.Error):void} onError Callback to call on error.
+ * @param {function(!remoting.Error):void} onError Callback to call on error.
* @return {void} Nothing.
*/
remoting.HostDaemonFacade.prototype.generateKeyPair =
@@ -399,7 +399,7 @@ remoting.HostDaemonFacade.prototype.generateKeyPair =
* @param {Object} config The new config parameters.
* @param {function(remoting.HostController.AsyncResult):void} onDone
* Callback to be called when finished.
- * @param {function(remoting.Error):void} onError Callback to call on error.
+ * @param {function(!remoting.Error):void} onError Callback to call on error.
* @return {void} Nothing.
*/
remoting.HostDaemonFacade.prototype.updateDaemonConfig =
@@ -415,7 +415,7 @@ remoting.HostDaemonFacade.prototype.updateDaemonConfig =
* callback.
*
* @param {function(Object):void} onDone Callback to return result.
- * @param {function(remoting.Error):void} onError Callback to call on error.
+ * @param {function(!remoting.Error):void} onError Callback to call on error.
* @return {void} Nothing.
*/
remoting.HostDaemonFacade.prototype.getDaemonConfig =
@@ -428,7 +428,7 @@ remoting.HostDaemonFacade.prototype.getDaemonConfig =
* string of the form major.minor.build.patch.
*
* @param {function(string):void} onDone Callback to be called to return result.
- * @param {function(remoting.Error):void} onError Callback to call on error.
+ * @param {function(!remoting.Error):void} onError Callback to call on error.
* @return {void}
*/
remoting.HostDaemonFacade.prototype.getDaemonVersion =
@@ -448,7 +448,7 @@ remoting.HostDaemonFacade.prototype.getDaemonVersion =
*
* @param {function(boolean, boolean, boolean):void} onDone Callback to return
* result.
- * @param {function(remoting.Error):void} onError Callback to call on error.
+ * @param {function(!remoting.Error):void} onError Callback to call on error.
* @return {void} Nothing.
*/
remoting.HostDaemonFacade.prototype.getUsageStatsConsent =
@@ -463,7 +463,7 @@ remoting.HostDaemonFacade.prototype.getUsageStatsConsent =
* @param {boolean} consent Consent to report crash dumps.
* @param {function(remoting.HostController.AsyncResult):void} onDone
* Callback to return result.
- * @param {function(remoting.Error):void} onError Callback to call on error.
+ * @param {function(!remoting.Error):void} onError Callback to call on error.
* @return {void} Nothing.
*/
remoting.HostDaemonFacade.prototype.startDaemon =
@@ -480,7 +480,7 @@ remoting.HostDaemonFacade.prototype.startDaemon =
*
* @param {function(remoting.HostController.AsyncResult):void} onDone
* Callback to return result.
- * @param {function(remoting.Error):void} onError Callback to call on error.
+ * @param {function(!remoting.Error):void} onError Callback to call on error.
* @return {void} Nothing.
*/
remoting.HostDaemonFacade.prototype.stopDaemon =
@@ -493,7 +493,7 @@ remoting.HostDaemonFacade.prototype.stopDaemon =
*
* @param {function(remoting.HostController.State):void} onDone Callback to
* return result.
- * @param {function(remoting.Error):void} onError Callback to call on error.
+ * @param {function(!remoting.Error):void} onError Callback to call on error.
* @return {void} Nothing.
*/
remoting.HostDaemonFacade.prototype.getDaemonState =
@@ -506,7 +506,7 @@ remoting.HostDaemonFacade.prototype.getDaemonState =
*
* @param {function(Array<remoting.PairedClient>):void} onDone Callback to
* return result.
- * @param {function(remoting.Error):void} onError Callback to call on error.
+ * @param {function(!remoting.Error):void} onError Callback to call on error.
*/
remoting.HostDaemonFacade.prototype.getPairedClients =
function(onDone, onError) {
@@ -517,7 +517,7 @@ remoting.HostDaemonFacade.prototype.getPairedClients =
* Clears all paired clients from the registry.
*
* @param {function(boolean):void} onDone Callback to be called when finished.
- * @param {function(remoting.Error):void} onError Callback to call on error.
+ * @param {function(!remoting.Error):void} onError Callback to call on error.
*/
remoting.HostDaemonFacade.prototype.clearPairedClients =
function(onDone, onError) {
@@ -529,7 +529,7 @@ remoting.HostDaemonFacade.prototype.clearPairedClients =
*
* @param {string} client Client to delete.
* @param {function(boolean):void} onDone Callback to be called when finished.
- * @param {function(remoting.Error):void} onError Callback to call on error.
+ * @param {function(!remoting.Error):void} onError Callback to call on error.
*/
remoting.HostDaemonFacade.prototype.deletePairedClient =
function(client, onDone, onError) {
@@ -543,7 +543,7 @@ remoting.HostDaemonFacade.prototype.deletePairedClient =
* Gets the API keys to obtain/use service account credentials.
*
* @param {function(string):void} onDone Callback to return result.
- * @param {function(remoting.Error):void} onError Callback to call on error.
+ * @param {function(!remoting.Error):void} onError Callback to call on error.
* @return {void} Nothing.
*/
remoting.HostDaemonFacade.prototype.getHostClientId =
@@ -555,7 +555,7 @@ remoting.HostDaemonFacade.prototype.getHostClientId =
*
* @param {string} authorizationCode OAuth authorization code.
* @param {function(string, string):void} onDone Callback to return result.
- * @param {function(remoting.Error):void} onError Callback to call on error.
+ * @param {function(!remoting.Error):void} onError Callback to call on error.
* @return {void} Nothing.
*/
remoting.HostDaemonFacade.prototype.getCredentialsFromAuthCode =

Powered by Google App Engine
This is Rietveld 408576698