remoting/webapp/crd/js/identity.js - Issue 955283002: Converted remoting.Error from an enum to a class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/webapp/crd/js/identity.js

Issue 955283002: Converted remoting.Error from an enum to a class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Smaller diff. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/webapp/crd/js/identity.js

diff --git a/remoting/webapp/crd/js/identity.js b/remoting/webapp/crd/js/identity.js

index 28258168aad4a887bdd3ed35123cd7d54c4ac2b2..86d6eb9d608ea68ea69f917990a1f232aecf1d53 100644

--- a/remoting/webapp/crd/js/identity.js

+++ b/remoting/webapp/crd/js/identity.js

@@ -213,7 +213,8 @@ remoting.Identity.prototype.onAuthComplete_ = function(interactive, token) {

chrome.runtime.lastError ? chrome.runtime.lastError.message

: 'Unknown error.';

console.error(error_message);

- authTokenDeferred.reject(remoting.Error.NOT_AUTHENTICATED);

+ authTokenDeferred.reject(

+ remoting.Error.NOT_AUTHENTICATED);

Jamie 2015/02/26 18:57:42 No need for a new line here.

John Williams 2015/02/27 21:42:11 Oops, relic of a previous version of the CL.

return;

}