remoting/webapp/browser_test/mock_oauth2_api.js - Issue 955283002: Converted remoting.Error from an enum to a class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/webapp/browser_test/mock_oauth2_api.js

Issue 955283002: Converted remoting.Error from an enum to a class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Smaller diff. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/webapp/browser_test/mock_oauth2_api.js

diff --git a/remoting/webapp/browser_test/mock_oauth2_api.js b/remoting/webapp/browser_test/mock_oauth2_api.js

index a64fe19a8efe378a26913148910bfdff941f8115..412ddaa182684b60b8c994114910be4496f0d64f 100644

--- a/remoting/webapp/browser_test/mock_oauth2_api.js

+++ b/remoting/webapp/browser_test/mock_oauth2_api.js

@@ -32,7 +32,7 @@ remoting.MockOAuth2Api = function() {

/**

* @param {function(string, number): void} onDone

- * @param {function(remoting.Error):void} onError

+ * @param {function(!remoting.Error):void} onError

* @param {string} clientId

* @param {string} clientSecret

* @param {string} refreshToken

@@ -47,7 +47,7 @@ remoting.MockOAuth2Api.prototype.refreshAccessToken = function(

/**

* @param {function(string, string, number): void} onDone

- * @param {function(remoting.Error):void} onError

+ * @param {function(!remoting.Error):void} onError

* @param {string} clientId

* @param {string} clientSecret

* @param {string} code

@@ -63,7 +63,7 @@ remoting.MockOAuth2Api.prototype.exchangeCodeForTokens = function(

/**

* @param {function(string,string)} onDone

- * @param {function(remoting.Error)} onError

+ * @param {function(!remoting.Error)} onError

* @param {string} token

remoting.MockOAuth2Api.prototype.getEmail = function(onDone, onError, token) {

@@ -73,7 +73,7 @@ remoting.MockOAuth2Api.prototype.getEmail = function(onDone, onError, token) {

/**

* @param {function(string,string)} onDone

- * @param {function(remoting.Error)} onError

+ * @param {function(!remoting.Error)} onError

* @param {string} token

remoting.MockOAuth2Api.prototype.getUserInfo =