Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Unified Diff: remoting/webapp/crd/js/wcs_loader.js

Issue 955283002: Converted remoting.Error from an enum to a class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/webapp/crd/js/wcs_adapter.js ('k') | remoting/webapp/crd/js/xmpp_connection.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/webapp/crd/js/wcs_loader.js
diff --git a/remoting/webapp/crd/js/wcs_loader.js b/remoting/webapp/crd/js/wcs_loader.js
index 59299160798dad5a58ea09b16def7971b309277b..a2ed3b119cfa284a217b705683a85bbb26812006 100644
--- a/remoting/webapp/crd/js/wcs_loader.js
+++ b/remoting/webapp/crd/js/wcs_loader.js
@@ -53,7 +53,7 @@ remoting.WcsLoader.prototype.start = function(token, onReady, onError) {
var node = document.getElementById(this.SCRIPT_NODE_ID_);
if (node) {
console.error('Multiple calls to WcsLoader.start are not allowed.');
- onError(remoting.Error.UNEXPECTED);
+ onError(remoting.Error.unexpected());
return;
}
@@ -83,10 +83,11 @@ remoting.WcsLoader.prototype.start = function(token, onReady, onError) {
// there's something wrong with the talkgadget service, or there is a
// cookie problem. Only the cookie problem can be fixed by the user, so
// suggest that fix.
- onValidateError(remoting.Error.AUTHENTICATION_FAILED);
- }
+ onValidateError(new remoting.Error(
+ remoting.Error.Tag.AUTHENTICATION_FAILED));
+ };
that.validateToken(token, onValidateOk, onValidateError);
- }
+ };
node.addEventListener('load', onLoad, false);
node.addEventListener('error', onLoadError, false);
};
@@ -124,14 +125,14 @@ remoting.WcsLoader.prototype.validateToken = function(token, onOk, onError) {
if (xhr.status == 200) {
onOk();
} else {
- var error = remoting.Error.AUTHENTICATION_FAILED;
+ var error = new remoting.Error(remoting.Error.Tag.AUTHENTICATION_FAILED);
switch (xhr.status) {
case 0:
- error = remoting.Error.NETWORK_FAILURE;
+ error = new remoting.Error(remoting.Error.Tag.NETWORK_FAILURE);
break;
case 502: // No break
case 503:
- error = remoting.Error.SERVICE_UNAVAILABLE;
+ error = new remoting.Error(remoting.Error.Tag.SERVICE_UNAVAILABLE);
break;
}
onError(error);
« no previous file with comments | « remoting/webapp/crd/js/wcs_adapter.js ('k') | remoting/webapp/crd/js/xmpp_connection.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698