Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(991)

Unified Diff: remoting/webapp/crd/js/it2me_connect_flow.js

Issue 955283002: Converted remoting.Error from an enum to a class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/webapp/crd/js/host_setup_dialog.js ('k') | remoting/webapp/crd/js/it2me_host_facade.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/webapp/crd/js/it2me_connect_flow.js
diff --git a/remoting/webapp/crd/js/it2me_connect_flow.js b/remoting/webapp/crd/js/it2me_connect_flow.js
index 00dabf3979f9aa447ee8ddb12f8224efd5c6b16f..20f42c2c65701f73323d2795183679a21ab96474 100644
--- a/remoting/webapp/crd/js/it2me_connect_flow.js
+++ b/remoting/webapp/crd/js/it2me_connect_flow.js
@@ -74,7 +74,8 @@ remoting.It2MeConnectFlow.prototype.connect_ = function(accessCode) {
remoting.It2MeConnectFlow.prototype.verifyAccessCode_ = function(accessCode) {
var normalizedAccessCode = accessCode.replace(/\s/g, '');
if (normalizedAccessCode.length !== ACCESS_CODE_LENGTH) {
- return Promise.reject(remoting.Error.INVALID_ACCESS_CODE);
+ return Promise.reject(new remoting.Error(
+ remoting.Error.Tag.INVALID_ACCESS_CODE));
}
this.hostId_ = normalizedAccessCode.substring(0, SUPPORT_ID_LENGTH);
@@ -124,7 +125,7 @@ remoting.It2MeConnectFlow.prototype.onHostInfo_ = function(xhr) {
return Promise.resolve(host);
} else {
console.error('Invalid "support-hosts" response from server.');
- return Promise.reject(remoting.Error.UNEXPECTED);
+ return Promise.reject(remoting.Error.unexpected());
}
} else {
return Promise.reject(translateSupportHostsError(xhr.status));
@@ -138,11 +139,11 @@ remoting.It2MeConnectFlow.prototype.onHostInfo_ = function(xhr) {
*/
function translateSupportHostsError(error) {
switch (error) {
- case 0: return remoting.Error.NETWORK_FAILURE;
- case 404: return remoting.Error.INVALID_ACCESS_CODE;
+ case 0: return new remoting.Error(remoting.Error.Tag.NETWORK_FAILURE);
+ case 404: return new remoting.Error(remoting.Error.Tag.INVALID_ACCESS_CODE);
case 502: // No break
- case 503: return remoting.Error.SERVICE_UNAVAILABLE;
- default: return remoting.Error.UNEXPECTED;
+ case 503: return new remoting.Error(remoting.Error.Tag.SERVICE_UNAVAILABLE);
+ default: return remoting.Error.unexpected();
}
}
« no previous file with comments | « remoting/webapp/crd/js/host_setup_dialog.js ('k') | remoting/webapp/crd/js/it2me_host_facade.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698