Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: remoting/webapp/crd/js/host_screen.js

Issue 955283002: Converted remoting.Error from an enum to a class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/webapp/crd/js/host_list_api_impl.js ('k') | remoting/webapp/crd/js/host_setup_dialog.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/webapp/crd/js/host_screen.js
diff --git a/remoting/webapp/crd/js/host_screen.js b/remoting/webapp/crd/js/host_screen.js
index 13dcd6a8d7333cae22cf4f4c5cffccaaced0abb4..bdbbb1e0563fba23fb26f1a7c1d9e12edb09aeb4 100644
--- a/remoting/webapp/crd/js/host_screen.js
+++ b/remoting/webapp/crd/js/host_screen.js
@@ -59,7 +59,7 @@ remoting.tryShare = function() {
/** @param {!remoting.Error} error */
var onInstallError = function(error) {
- if (error.tag == remoting.Error.Tag.CANCELLED) {
+ if (error.hasTag(remoting.Error.Tag.CANCELLED)) {
remoting.setMode(remoting.AppMode.HOME);
} else {
showShareError_(error);
@@ -169,10 +169,10 @@ function onHostStateChanged_(state) {
cleanUp();
} else if (state == remoting.HostSession.State.ERROR) {
console.error('Host state: ERROR');
- showShareError_(remoting.Error.UNEXPECTED);
+ showShareError_(remoting.Error.unexpected());
} else if (state == remoting.HostSession.State.INVALID_DOMAIN_ERROR) {
console.error('Host state: INVALID_DOMAIN_ERROR');
- showShareError_(remoting.Error.INVALID_HOST_DOMAIN);
+ showShareError_(new remoting.Error(remoting.Error.Tag.INVALID_HOST_DOMAIN));
} else {
console.error('Unknown state -> ' + state);
}
@@ -211,7 +211,7 @@ function it2meConnectFailed_() {
// We probably want to add a new error code (with the corresponding error
// message for sharing error.
console.error('Cannot share desktop.');
- showShareError_(remoting.Error.UNEXPECTED);
+ showShareError_(remoting.Error.unexpected());
}
function cleanUp() {
@@ -237,7 +237,7 @@ remoting.cancelShare = function() {
// the host plugin, like we do for the client, which should handle crash
// reporting and it should use a more detailed error message than the
// default 'generic' one. See crbug.com/94624
- showShareError_(remoting.Error.UNEXPECTED);
+ showShareError_(remoting.Error.unexpected());
}
disableTimeoutCountdown_();
};
« no previous file with comments | « remoting/webapp/crd/js/host_list_api_impl.js ('k') | remoting/webapp/crd/js/host_setup_dialog.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698