remoting/webapp/crd/js/desktop_remoting.js - Issue 955283002: Converted remoting.Error from an enum to a class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/webapp/crd/js/desktop_remoting.js

Issue 955283002: Converted remoting.Error from an enum to a class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/webapp/crd/js/desktop_remoting.js

diff --git a/remoting/webapp/crd/js/desktop_remoting.js b/remoting/webapp/crd/js/desktop_remoting.js

index c345d6444320779d5b2f807a34b0d22e1e06c9e6..98b62a438d04f32b6c3c7767eb3f0b72250c8629 100644

--- a/remoting/webapp/crd/js/desktop_remoting.js

+++ b/remoting/webapp/crd/js/desktop_remoting.js

@@ -266,7 +266,7 @@ remoting.DesktopRemoting.prototype.handleConnectionFailed = function(

that.handleError(error);

};

- if (error.tag == remoting.Error.Tag.HOST_IS_OFFLINE &&

+ if (error.hasTag(remoting.Error.Tag.HOST_IS_OFFLINE) &&

that.refreshHostJidIfOffline_) {

that.refreshHostJidIfOffline_ = false;

// The plugin will be re-created when the host finished refreshing

@@ -305,7 +305,7 @@ remoting.DesktopRemoting.prototype.handleError = function(error) {

console.error('Connection failed:', error.tag);

remoting.accessCode = '';

- if (error.tag === remoting.Error.Tag.AUTHENTICATION_FAILED) {

+ if (error.hasTag(remoting.Error.Tag.AUTHENTICATION_FAILED)) {

remoting.setMode(remoting.AppMode.HOME);

remoting.handleAuthFailureAndRelaunch();

return;