Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: remoting/webapp/crd/js/wcs_sandbox_container.js

Issue 955283002: Converted remoting.Error from an enum to a class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/crd/js/wcs_sandbox_container.js
diff --git a/remoting/webapp/crd/js/wcs_sandbox_container.js b/remoting/webapp/crd/js/wcs_sandbox_container.js
index 521dfbe9434689080c552f3433225c07429259c7..dd41e0e139038184a550df8619cbdb0df22b491b 100644
--- a/remoting/webapp/crd/js/wcs_sandbox_container.js
+++ b/remoting/webapp/crd/js/wcs_sandbox_container.js
@@ -24,7 +24,7 @@ remoting.WcsSandboxContainer = function(sandbox) {
this.sandbox_ = sandbox;
/** @private {?function(string):void} */
this.onConnected_ = null;
- /** @private {function(remoting.Error):void} */
+ /** @private {function(!remoting.Error):void} */
this.onError_ = function(error) {};
/** @private {?function(string):void} */
this.onIq_ = null;
@@ -49,7 +49,7 @@ remoting.WcsSandboxContainer = function(sandbox) {
/**
* @param {function(string):void} onConnected Callback to be called when WCS is
* connected. May be called synchronously if WCS is already connected.
- * @param {function(remoting.Error):void} onError called in case of an error.
+ * @param {function(!remoting.Error):void} onError called in case of an error.
* @return {void} Nothing.
*/
remoting.WcsSandboxContainer.prototype.connect = function(
@@ -147,7 +147,7 @@ remoting.WcsSandboxContainer.prototype.onMessage_ = function(event) {
break;
case 'onError':
- /** @type {remoting.Error} */
+ /** @type {!remoting.Error} */
var error = event.data['error'];
if (error === undefined) {
console.error('onError: missing error code');

Powered by Google App Engine
This is Rietveld 408576698