Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2190)

Unified Diff: remoting/webapp/crd/js/session_connector_impl.js

Issue 955283002: Converted remoting.Error from an enum to a class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/crd/js/session_connector_impl.js
diff --git a/remoting/webapp/crd/js/session_connector_impl.js b/remoting/webapp/crd/js/session_connector_impl.js
index da0e9a822b3a75c5ab96dd61087447c7f33225b7..b3e22acca7c9261535f6d65b22aa8b108326f28c 100644
--- a/remoting/webapp/crd/js/session_connector_impl.js
+++ b/remoting/webapp/crd/js/session_connector_impl.js
@@ -16,11 +16,11 @@ var remoting = remoting || {};
* @param {HTMLElement} clientContainer Container element for the client view.
* @param {function(remoting.ClientSession):void} onConnected Callback on
* success.
- * @param {function(remoting.Error):void} onError Callback on error.
+ * @param {function(!remoting.Error):void} onError Callback on error.
* @param {function(string, string):boolean} onExtensionMessage The handler for
* protocol extension messages. Returns true if a message is recognized;
* false otherwise.
- * @param {function(remoting.Error):void} onConnectionFailed Callback for when
+ * @param {function(!remoting.Error):void} onConnectionFailed Callback for when
* the connection fails.
* @param {Array<string>} requiredCapabilities Connector capabilities
* required by this application.
@@ -40,13 +40,13 @@ remoting.SessionConnectorImpl = function(clientContainer, onConnected, onError,
/** @private {function(remoting.ClientSession):void} */
this.onConnected_ = onConnected;
- /** @private {function(remoting.Error):void} */
+ /** @private {function(!remoting.Error):void} */
this.onError_ = onError;
/** @private {function(string, string):boolean} */
this.onExtensionMessage_ = onExtensionMessage;
- /** @private {function(remoting.Error):void} */
+ /** @private {function(!remoting.Error):void} */
this.onConnectionFailed_ = onConnectionFailed;
/** @private {Array<string>} */
@@ -474,7 +474,7 @@ remoting.SessionConnectorImpl.prototype.onStateChange_ = function(event) {
/**
* @param {number} error An HTTP error code returned by the support-hosts
* endpoint.
- * @return {remoting.Error} The equivalent remoting.Error code.
+ * @return {!remoting.Error} The equivalent remoting.Error code.
* @private
*/
remoting.SessionConnectorImpl.prototype.translateSupportHostsError_ =
@@ -513,11 +513,11 @@ remoting.DefaultSessionConnectorFactory = function() {
* @param {HTMLElement} clientContainer Container element for the client view.
* @param {function(remoting.ClientSession):void} onConnected Callback on
* success.
- * @param {function(remoting.Error):void} onError Callback on error.
+ * @param {function(!remoting.Error):void} onError Callback on error.
* @param {function(string, string):boolean} onExtensionMessage The handler for
* protocol extension messages. Returns true if a message is recognized;
* false otherwise.
- * @param {function(remoting.Error):void} onConnectionFailed Callback for when
+ * @param {function(!remoting.Error):void} onConnectionFailed Callback for when
* the connection fails.
* @param {Array<string>} requiredCapabilities Connector capabilities
* required by this application.

Powered by Google App Engine
This is Rietveld 408576698