Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Unified Diff: remoting/webapp/crd/js/desktop_remoting.js

Issue 955283002: Converted remoting.Error from an enum to a class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/crd/js/desktop_remoting.js
diff --git a/remoting/webapp/crd/js/desktop_remoting.js b/remoting/webapp/crd/js/desktop_remoting.js
index 6eb06260103f703d92681c70e379de3864263f8d..1f5691282ef2d2b23a99d800c48482cddac09ff7 100644
--- a/remoting/webapp/crd/js/desktop_remoting.js
+++ b/remoting/webapp/crd/js/desktop_remoting.js
@@ -137,7 +137,7 @@ remoting.DesktopRemoting.prototype.start = function(connector, token) {
* Report an authentication error to the user. This is called in lieu of start()
* if the user cannot be authenticated or if they decline the app permissions.
*
- * @param {remoting.Error} error The failure reason.
+ * @param {!remoting.Error} error The failure reason.
*/
remoting.DesktopRemoting.prototype.signInFailed = function(error) {
if (error == remoting.Error.CANCELLED) {
@@ -250,7 +250,7 @@ remoting.DesktopRemoting.prototype.handleDisconnected = function() {
* Called when the current session's connection has failed.
*
* @param {remoting.SessionConnector} connector
- * @param {remoting.Error} error
+ * @param {!remoting.Error} error
* @return {void} Nothing.
*/
remoting.DesktopRemoting.prototype.handleConnectionFailed = function(
@@ -270,7 +270,7 @@ remoting.DesktopRemoting.prototype.handleConnectionFailed = function(
that.handleError(error);
};
- if (error == remoting.Error.HOST_IS_OFFLINE &&
+ if (error.tag == remoting.Error.Tag.HOST_IS_OFFLINE &&
that.refreshHostJidIfOffline_) {
that.refreshHostJidIfOffline_ = false;
// The plugin will be re-created when the host finished refreshing
@@ -302,14 +302,14 @@ remoting.DesktopRemoting.prototype.handleExtensionMessage = function(
/**
* Called when an error needs to be displayed to the user.
*
- * @param {remoting.Error} errorTag The error to be localized and displayed.
+ * @param {!remoting.Error} error The error to be localized and displayed.
* @return {void} Nothing.
*/
-remoting.DesktopRemoting.prototype.handleError = function(errorTag) {
- console.error('Connection failed: ' + errorTag);
+remoting.DesktopRemoting.prototype.handleError = function(error) {
+ console.error('Connection failed:', error.tag);
remoting.accessCode = '';
- if (errorTag === remoting.Error.AUTHENTICATION_FAILED) {
+ if (error.tag === remoting.Error.Tag.AUTHENTICATION_FAILED) {
remoting.setMode(remoting.AppMode.HOME);
remoting.handleAuthFailureAndRelaunch();
return;
@@ -319,7 +319,7 @@ remoting.DesktopRemoting.prototype.handleError = function(errorTag) {
this.refreshHostJidIfOffline_ = true;
var errorDiv = document.getElementById('connect-error-message');
- l10n.localizeElementFromTag(errorDiv, /** @type {string} */ (errorTag));
+ l10n.localizeElementFromTag(errorDiv, error.tag);
var mode = remoting.clientSession ? remoting.desktopConnectedView.getMode()
: this.app_.getSessionConnector().getConnectionMode();

Powered by Google App Engine
This is Rietveld 408576698