Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Unified Diff: remoting/webapp/base/js/application.js

Issue 955283002: Converted remoting.Error from an enum to a class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/base/js/application.js
diff --git a/remoting/webapp/base/js/application.js b/remoting/webapp/base/js/application.js
index 5ba56f8ff67d633b771aa6e00b1c5ea0fa0bfe2b..a310114f326da6992c1d922694f1d3e4d77cb0c4 100644
--- a/remoting/webapp/base/js/application.js
+++ b/remoting/webapp/base/js/application.js
@@ -144,7 +144,7 @@ remoting.Application.prototype.onDisconnected = function() {
/**
* Called when the current session's connection has failed.
*
- * @param {remoting.Error} error
+ * @param {!remoting.Error} error
* @return {void} Nothing.
*/
remoting.Application.prototype.onConnectionFailed = function(error) {
@@ -188,7 +188,7 @@ remoting.Application.prototype.onExtensionMessage = function(type, data) {
/**
* Called when an error needs to be displayed to the user.
*
- * @param {remoting.Error} errorTag The error to be localized and displayed.
+ * @param {!remoting.Error} errorTag The error to be localized and displayed.
* @return {void} Nothing.
*/
remoting.Application.prototype.onError = function(errorTag) {
@@ -284,7 +284,7 @@ remoting.Application.Delegate.prototype.start = function(connector, token) {};
* Report an authentication error to the user. This is called in lieu of start()
* if the user cannot be authenticated or if they decline the app permissions.
*
- * @param {remoting.Error} error The failure reason.
+ * @param {!remoting.Error} error The failure reason.
*/
remoting.Application.Delegate.prototype.signInFailed = function(error) {};
@@ -318,7 +318,7 @@ remoting.Application.Delegate.prototype.handleDisconnected = function() {};
* Called when the current session's connection has failed.
*
* @param {remoting.SessionConnector} connector
- * @param {remoting.Error} error
+ * @param {!remoting.Error} error
* @return {void} Nothing.
*/
remoting.Application.Delegate.prototype.handleConnectionFailed =
@@ -346,7 +346,7 @@ remoting.Application.Delegate.prototype.handleExtensionMessage =
/**
* Called when an error needs to be displayed to the user.
*
- * @param {remoting.Error} errorTag The error to be localized and displayed.
+ * @param {!remoting.Error} errorTag The error to be localized and displayed.
* @return {void} Nothing.
*/
remoting.Application.Delegate.prototype.handleError = function(errorTag) {};

Powered by Google App Engine
This is Rietveld 408576698