Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Unified Diff: remoting/webapp/app_remoting/js/app_remoting.js

Issue 955283002: Converted remoting.Error from an enum to a class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | remoting/webapp/app_remoting/js/loading_window.js » ('j') | remoting/webapp/crd/js/error.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/webapp/app_remoting/js/app_remoting.js
diff --git a/remoting/webapp/app_remoting/js/app_remoting.js b/remoting/webapp/app_remoting/js/app_remoting.js
index fb14f6d06827f24e5a6490fff0a577a5fba0002d..30176d0de865c8ebc38ee8dca9b7aad2424a2cb0 100644
--- a/remoting/webapp/app_remoting/js/app_remoting.js
+++ b/remoting/webapp/app_remoting/js/app_remoting.js
@@ -181,10 +181,10 @@ remoting.AppRemoting.prototype.start = function(connector, token) {
* Report an authentication error to the user. This is called in lieu of start()
* if the user cannot be authenticated or if they decline the app permissions.
*
- * @param {remoting.Error} error The failure reason.
+ * @param {!remoting.Error} error The failure reason.
*/
remoting.AppRemoting.prototype.signInFailed = function(error) {
- if (error == remoting.Error.CANCELLED) {
+ if (error.tag == remoting.Error.Tag.CANCELLED) {
chrome.app.window.current().close();
remoting.LoadingWindow.close();
} else {
@@ -257,7 +257,7 @@ remoting.AppRemoting.prototype.handleDisconnected = function() {
* Called when the current session's connection has failed.
*
* @param {remoting.SessionConnector} connector
- * @param {remoting.Error} error
+ * @param {!remoting.Error} error
* @return {void} Nothing.
*/
remoting.AppRemoting.prototype.handleConnectionFailed = function(
@@ -333,7 +333,7 @@ remoting.AppRemoting.prototype.handleExtensionMessage = function(
/**
* Called when an error needs to be displayed to the user.
*
- * @param {remoting.Error} errorTag The error to be localized and displayed.
+ * @param {!remoting.Error} errorTag The error to be localized and displayed.
* @return {void} Nothing.
*/
remoting.AppRemoting.prototype.handleError = function(errorTag) {
« no previous file with comments | « no previous file | remoting/webapp/app_remoting/js/loading_window.js » ('j') | remoting/webapp/crd/js/error.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698