Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Side by Side Diff: remoting/webapp/unittests/xmpp_connection_unittest.js

Issue 955283002: Converted remoting.Error from an enum to a class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Requested changes. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 (function() { 5 (function() {
6 6
7 'use strict'; 7 'use strict';
8 8
9 var testUsername = 'testUsername@gmail.com'; 9 var testUsername = 'testUsername@gmail.com';
10 var testToken = 'testToken'; 10 var testToken = 'testToken';
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 'xmpp.example.com:123', 'testUsername@gmail.com', 'testToken'); 49 'xmpp.example.com:123', 'testUsername@gmail.com', 'testToken');
50 sinon.assert.calledWith(onStateChange, 50 sinon.assert.calledWith(onStateChange,
51 remoting.SignalStrategy.State.CONNECTING); 51 remoting.SignalStrategy.State.CONNECTING);
52 sinon.assert.calledWith(chrome.socket.create, "tcp", {}); 52 sinon.assert.calledWith(chrome.socket.create, "tcp", {});
53 chrome.socket.create.getCall(0).args[2]({socketId: socketId}); 53 chrome.socket.create.getCall(0).args[2]({socketId: socketId});
54 54
55 sinon.assert.calledWith( 55 sinon.assert.calledWith(
56 chrome.socket.connect, socketId, "xmpp.example.com", 123); 56 chrome.socket.connect, socketId, "xmpp.example.com", 123);
57 chrome.socket.connect.getCall(0).args[3](-1); 57 chrome.socket.connect.getCall(0).args[3](-1);
58 58
59 QUnit.equal(connection.getError(), remoting.Error.NETWORK_FAILURE); 59 QUnit.equal(connection.getError().tag, remoting.Error.Tag.NETWORK_FAILURE);
60 }); 60 });
61 61
62 test('should use XmppLoginHandler to complete handshake and read data', 62 test('should use XmppLoginHandler to complete handshake and read data',
63 function() { 63 function() {
64 connection.connect( 64 connection.connect(
65 'xmpp.example.com:123', 'testUsername@gmail.com', 'testToken'); 65 'xmpp.example.com:123', 'testUsername@gmail.com', 'testToken');
66 sinon.assert.calledWith(onStateChange, 66 sinon.assert.calledWith(onStateChange,
67 remoting.SignalStrategy.State.CONNECTING); 67 remoting.SignalStrategy.State.CONNECTING);
68 sinon.assert.calledWith(chrome.socket.create, "tcp", {}); 68 sinon.assert.calledWith(chrome.socket.create, "tcp", {});
69 chrome.socket.create.getCall(0).args[2]({socketId: socketId}); 69 chrome.socket.create.getCall(0).args[2]({socketId: socketId});
(...skipping 16 matching lines...) Expand all
86 86
87 // Simulate read() callback with |data|. It should be passed to the parser. 87 // Simulate read() callback with |data|. It should be passed to the parser.
88 var data = base.encodeUtf8('<iq id="1">hello</iq>'); 88 var data = base.encodeUtf8('<iq id="1">hello</iq>');
89 sinon.assert.calledWith(chrome.socket.read, socketId); 89 sinon.assert.calledWith(chrome.socket.read, socketId);
90 var appendDataCalled = parserMock.expects('appendData').once().withArgs(data); 90 var appendDataCalled = parserMock.expects('appendData').once().withArgs(data);
91 chrome.socket.read.getCall(0).args[1]({resultCode: 0, data: data}); 91 chrome.socket.read.getCall(0).args[1]({resultCode: 0, data: data});
92 appendDataCalled.verify(); 92 appendDataCalled.verify();
93 }); 93 });
94 94
95 })(); 95 })();
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698