Converted remoting.Error from an enum to a class

remoting/webapp/crd/js/host_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * Class representing the host-list portion of the home screen UI.
  */
 
 'use strict';
@@ skipping 49 matching lines @@
    * @type {Array<remoting.HostTableEntry>}
    * @private
    */
   this.hostTableEntries_ = [];
   /**
    * @type {Array<remoting.Host>}
    * @private
    */
   this.hosts_ = [];
   /**
-   * @type {string}
+   * @type {!remoting.Error}
    * @private
    */
-  this.lastError_ = '';
+  this.lastError_ = remoting.Error.NONE;
   /**
    * @type {remoting.Host?}
    * @private
    */
   this.localHost_ = null;
   /**
    * @type {remoting.HostController.State}
    * @private
    */
   this.localHostState_ = remoting.HostController.State.UNKNOWN;
@@ skipping 76 matching lines @@
  * Query the Remoting Directory for the user's list of hosts.
  *
  * @param {function(boolean):void} onDone Callback invoked with true on success
  *     or false on failure.
  * @return {void} Nothing.
  */
 remoting.HostList.prototype.refresh = function(onDone) {
   this.loadingIndicator_.classList.add('loading');
   /** @type {remoting.HostList} */
   var that = this;
-  /** @param {remoting.Error} error */
+  /** @param {!remoting.Error} error */
   var onError = function(error) {
     that.lastError_ = error;
     onDone(false);
   };
   remoting.hostListApi.get(this.onHostListResponse_.bind(this, onDone),
                            onError);
 };
 
 /**
  * Handle the results of the host list request.  A success response will
  * include a JSON-encoded list of host descriptions, which we display if we're
  * able to successfully parse it.
  *
  * @param {function(boolean):void} onDone The callback passed to |refresh|.
  * @param {Array<remoting.Host>} hosts The list of hosts for the user.
  * @return {void} Nothing.
  * @private
  */
 remoting.HostList.prototype.onHostListResponse_ = function(onDone, hosts) {
-  this.lastError_ = '';
+  this.lastError_ = remoting.Error.NONE;
   this.hosts_ = hosts;
   this.sortHosts_();
   this.save_();
   this.loadingIndicator_.classList.remove('loading');
-  onDone(this.lastError_ == '');
+  onDone(this.lastError_.tag == remoting.Error.Tag.NONE);

[Jamie, 2015/02/26 18:57:42]

Not strictly related to your changes, but since neither sortHosts_ nor save_ can
set lastError_, you might as well just pass true here.

[John Williams, 2015/02/27 21:42:11]

Done.

 };
 
 /**
  * Sort the internal list of hosts.
  *
  * @suppress {reportUnknownTypes}
  * @return {void} Nothing.
  */
 remoting.HostList.prototype.sortHosts_ = function() {
   /**
@@ skipping 29 matching lines @@
 remoting.HostList.prototype.display = function() {
   this.table_.innerText = '';
   this.errorMsg_.innerText = '';
   this.hostTableEntries_ = [];
 
   var noHostsRegistered = (this.hosts_.length == 0);
   this.table_.hidden = noHostsRegistered;
   this.noHosts_.hidden = !noHostsRegistered;
 
   if (this.lastError_ != '') {
-    l10n.localizeElementFromTag(this.errorMsg_, this.lastError_);
-    if (this.lastError_ == remoting.Error.AUTHENTICATION_FAILED) {
+    l10n.localizeElementFromTag(this.errorMsg_, this.lastError_.tag);
+    if (this.lastError_.tag == remoting.Error.Tag.AUTHENTICATION_FAILED) {
       l10n.localizeElementFromTag(this.errorButton_,
                                   /*i18n-content*/'SIGN_IN_BUTTON');
     } else {
       l10n.localizeElementFromTag(this.errorButton_,
                                   /*i18n-content*/'RETRY');
     }
   } else {
     for (var i = 0; i < this.hosts_.length; ++i) {
       /** @type {remoting.Host} */
       var host = this.hosts_[i];
@@ skipping 217 matching lines @@
   this.setLocalHost_(localHost);
 };
 
 /**
  * Called when the user clicks the button next to the error message. The action
  * depends on the error.
  *
  * @private
  */
 remoting.HostList.prototype.onErrorClick_ = function() {
-  if (this.lastError_ == remoting.Error.AUTHENTICATION_FAILED) {
+  if (this.lastError_.tag == remoting.Error.Tag.AUTHENTICATION_FAILED) {
     remoting.handleAuthFailureAndRelaunch();
   } else {
     this.refresh(remoting.updateLocalHostState);
   }
 };
 
 /**
  * Save the host list to local storage.
  */
 remoting.HostList.prototype.save_ = function() {
   var items = {};
   items[remoting.HostList.HOSTS_KEY] = JSON.stringify(this.hosts_);
   chrome.storage.local.set(items);
   if (this.hosts_.length !== 0) {
     remoting.AppsV2Migration.saveUserInfo();
   }
 };
 
 /**
  * Key name under which Me2Me hosts are cached.
  */
 remoting.HostList.HOSTS_KEY = 'me2me-cached-hosts';
 
 /** @type {remoting.HostList} */
 remoting.hostList = null;