Converted remoting.Error from an enum to a class

remoting/webapp/crd/js/desktop_remoting.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * This class implements the functionality that is specific to desktop
  * remoting ("Chromoting" or CRD).
  */
 
@@ skipping 221 matching lines @@
  *
  * @return {void} Nothing.
  */
 remoting.DesktopRemoting.prototype.handleDisconnected = function() {
 };
 
 /**
  * Called when the current session's connection has failed.
  *
  * @param {remoting.SessionConnector} connector
- * @param {remoting.Error} error
+ * @param {!remoting.Error} error
  * @return {void} Nothing.
  */
 remoting.DesktopRemoting.prototype.handleConnectionFailed = function(
     connector, error) {
   /** @type {remoting.DesktopRemoting} */
   var that = this;
 
   /** @param {boolean} success */
   var onHostListRefresh = function(success) {
     if (success) {
       var host = remoting.hostList.getHostForId(connector.getHostId());
       if (host) {
         connector.retryConnectMe2Me(host);
         return;
       }
     }
     that.handleError(error);
   };
 
-  if (error == remoting.Error.HOST_IS_OFFLINE &&
+  if (error.tag == remoting.Error.Tag.HOST_IS_OFFLINE &&
       that.refreshHostJidIfOffline_) {
     that.refreshHostJidIfOffline_ = false;
     // The plugin will be re-created when the host finished refreshing
     remoting.hostList.refresh(onHostListRefresh);
   } else {
     this.handleError(error);
   }
 };
 
 /**
@@ skipping 11 matching lines @@
  * @return {boolean} Return true if the extension message was recognized.
  */
 remoting.DesktopRemoting.prototype.handleExtensionMessage = function(
     type, message) {
   return false;
 };
 
 /**
  * Called when an error needs to be displayed to the user.
  *
- * @param {remoting.Error} errorTag The error to be localized and displayed.
+ * @param {!remoting.Error} error The error to be localized and displayed.
  * @return {void} Nothing.
  */
-remoting.DesktopRemoting.prototype.handleError = function(errorTag) {
-  console.error('Connection failed: ' + errorTag);
+remoting.DesktopRemoting.prototype.handleError = function(error) {
+  console.error('Connection failed: %o', error);

[Jamie, 2015/02/26 18:57:42]

IMO, the %o syntax is less clear than using "+". Is there any reason to prefer
it?

[John Williams, 2015/02/27 21:42:11]

If `error` is an object, using %o lets you browse its properties in the log
view; using + just prints something useless like "[object Object]".

[Jamie, 2015/03/02 18:28:09]

In that case, you can achieve the same effect with multiple parameters:

  console.log('Connection failed:', error)

Note no explicit space to separate them. This is the syntax we use elsewhere,
and I think it's clearer than %o.

However, in this case, I think it would be better to log the error tag
explicitly. We often ask users to copy/paste console logs, in which case we'll
lose details of the error messages with this change.

[John Williams, 2015/03/02 22:01:36]

Done.

   remoting.accessCode = '';
 
-  if (errorTag === remoting.Error.AUTHENTICATION_FAILED) {
+  if (error.tag === remoting.Error.Tag.AUTHENTICATION_FAILED) {
     remoting.setMode(remoting.AppMode.HOME);
     remoting.handleAuthFailureAndRelaunch();
     return;
   }
 
   // Reset the refresh flag so that the next connection will retry if needed.
   this.refreshHostJidIfOffline_ = true;
 
   var errorDiv = document.getElementById('connect-error-message');
-  l10n.localizeElementFromTag(errorDiv, /** @type {string} */ (errorTag));
+  l10n.localizeElementFromTag(errorDiv, error.tag);
 
   var mode = remoting.clientSession ? remoting.desktopConnectedView.getMode()
       : this.app_.getSessionConnector().getConnectionMode();
   if (mode == remoting.DesktopConnectedView.Mode.IT2ME) {
     remoting.setMode(remoting.AppMode.CLIENT_CONNECT_FAILED_IT2ME);
     remoting.hangoutSessionEvents.raiseEvent(
         remoting.hangoutSessionEvents.sessionStateChanged,
         remoting.ClientSession.State.FAILED
     );
   } else {
     remoting.setMode(remoting.AppMode.CLIENT_CONNECT_FAILED_ME2ME);
   }
 };