Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: remoting/webapp/unittests/xmpp_connection_unittest.js

Issue 955283002: Converted remoting.Error from an enum to a class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 (function() { 5 (function() {
6 6
7 'use strict'; 7 'use strict';
8 8
9 var testUsername = 'testUsername@gmail.com'; 9 var testUsername = 'testUsername@gmail.com';
10 var testToken = 'testToken'; 10 var testToken = 'testToken';
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 'xmpp.example.com:123', 'testUsername@gmail.com', 'testToken'); 56 'xmpp.example.com:123', 'testUsername@gmail.com', 'testToken');
57 sinon.assert.calledWith(onStateChange, 57 sinon.assert.calledWith(onStateChange,
58 remoting.SignalStrategy.State.CONNECTING); 58 remoting.SignalStrategy.State.CONNECTING);
59 sinon.assert.calledWith(chrome.socket.create, "tcp", {}); 59 sinon.assert.calledWith(chrome.socket.create, "tcp", {});
60 chrome.socket.create.$testStub.getCall(0).args[2]({socketId: socketId}); 60 chrome.socket.create.$testStub.getCall(0).args[2]({socketId: socketId});
61 61
62 sinon.assert.calledWith( 62 sinon.assert.calledWith(
63 chrome.socket.connect, socketId, "xmpp.example.com", 123); 63 chrome.socket.connect, socketId, "xmpp.example.com", 123);
64 chrome.socket.connect.$testStub.getCall(0).args[3](-1); 64 chrome.socket.connect.$testStub.getCall(0).args[3](-1);
65 65
66 QUnit.equal(connection.getError(), remoting.Error.NETWORK_FAILURE); 66 QUnit.equal(connection.getError().tag, remoting.Error.Tag.NETWORK_FAILURE);
67 }); 67 });
68 68
69 test('should use XmppLoginHandler to complete handshake and read data', 69 test('should use XmppLoginHandler to complete handshake and read data',
70 function() { 70 function() {
71 connection.connect( 71 connection.connect(
72 'xmpp.example.com:123', 'testUsername@gmail.com', 'testToken'); 72 'xmpp.example.com:123', 'testUsername@gmail.com', 'testToken');
73 sinon.assert.calledWith(onStateChange, 73 sinon.assert.calledWith(onStateChange,
74 remoting.SignalStrategy.State.CONNECTING); 74 remoting.SignalStrategy.State.CONNECTING);
75 sinon.assert.calledWith(chrome.socket.create, "tcp", {}); 75 sinon.assert.calledWith(chrome.socket.create, "tcp", {});
76 chrome.socket.create.$testStub.getCall(0).args[2]({socketId: socketId}); 76 chrome.socket.create.$testStub.getCall(0).args[2]({socketId: socketId});
(...skipping 17 matching lines...) Expand all
94 94
95 // Simulate read() callback with |data|. It should be passed to the parser. 95 // Simulate read() callback with |data|. It should be passed to the parser.
96 var data = base.encodeUtf8('<iq id="1">hello</iq>'); 96 var data = base.encodeUtf8('<iq id="1">hello</iq>');
97 sinon.assert.calledWith(chrome.socket.read, socketId); 97 sinon.assert.calledWith(chrome.socket.read, socketId);
98 var appendDataCalled = parserMock.expects('appendData').once().withArgs(data); 98 var appendDataCalled = parserMock.expects('appendData').once().withArgs(data);
99 chrome.socket.read.$testStub.getCall(0).args[1]({resultCode: 0, data: data}); 99 chrome.socket.read.$testStub.getCall(0).args[1]({resultCode: 0, data: data});
100 appendDataCalled.verify(); 100 appendDataCalled.verify();
101 }); 101 });
102 102
103 })(); 103 })();
OLDNEW
« remoting/webapp/crd/js/error.js ('K') | « remoting/webapp/unittests/mock_signal_strategy.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698