Converted remoting.Error from an enum to a class

remoting/webapp/crd/js/host_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * Class representing the host-list portion of the home screen UI.
  */
 
 'use strict';
@@ skipping 29 matching lines @@
   /** @private {Element} */
   this.errorMsg_ = errorMsg;
   /** @private {Element} */
   this.errorButton_ = errorButton;
   /** @private {HTMLElement} */
   this.loadingIndicator_ = loadingIndicator;
   /** @private {Array<remoting.HostTableEntry>} */
   this.hostTableEntries_ = [];
   /** @private {Array<remoting.Host>} */
   this.hosts_ = [];
-  /** @private {string} */
-  this.lastError_ = '';
+  /** @private {!remoting.Error} */
+  this.lastError_ = remoting.Error.NONE;
   /** @private {remoting.LocalHostSection} */
   this.localHostSection_ = new remoting.LocalHostSection(
       /** @type {HTMLElement} */ (document.querySelector('.daemon-control')),
       new remoting.LocalHostSection.Controller(
           this, new remoting.HostSetupDialog(remoting.hostController)));
 
   /** @private {number} */
   this.webappMajorVersion_ = parseInt(chrome.runtime.getManifest().version, 10);
 
   this.errorButton_.addEventListener('click',
@@ skipping 68 matching lines @@
  * Query the Remoting Directory for the user's list of hosts.
  *
  * @param {function(boolean):void} onDone Callback invoked with true on success
  *     or false on failure.
  * @return {void} Nothing.
  */
 remoting.HostList.prototype.refresh = function(onDone) {
   this.loadingIndicator_.classList.add('loading');
   /** @type {remoting.HostList} */
   var that = this;
-  /** @param {remoting.Error} error */
+  /** @param {!remoting.Error} error */
   var onError = function(error) {
     that.lastError_ = error;
     onDone(false);
   };
   remoting.hostListApi.get(this.onHostListResponse_.bind(this, onDone),
                            onError);
 };
 
 /**
  * Handle the results of the host list request.  A success response will
  * include a JSON-encoded list of host descriptions, which we display if we're
  * able to successfully parse it.
  *
  * @param {function(boolean):void} onDone The callback passed to |refresh|.
  * @param {Array<remoting.Host>} hosts The list of hosts for the user.
  * @return {void} Nothing.
  * @private
  */
 remoting.HostList.prototype.onHostListResponse_ = function(onDone, hosts) {
-  this.lastError_ = '';
+  this.lastError_ = remoting.Error.NONE;
   this.hosts_ = hosts;
   this.sortHosts_();
   this.save_();
   this.loadingIndicator_.classList.remove('loading');
-  onDone(this.lastError_ == '');
+  onDone(true);
 };
 
 /**
  * Sort the internal list of hosts.
  *
  * @suppress {reportUnknownTypes}
  * @return {void} Nothing.
  */
 remoting.HostList.prototype.sortHosts_ = function() {
   /**
@@ skipping 29 matching lines @@
 remoting.HostList.prototype.display = function() {
   this.table_.innerText = '';
   this.errorMsg_.innerText = '';
   this.hostTableEntries_ = [];
 
   var noHostsRegistered = (this.hosts_.length == 0);
   this.table_.hidden = noHostsRegistered;
   this.noHosts_.hidden = !noHostsRegistered;
 
   if (this.lastError_ != '') {
-    l10n.localizeElementFromTag(this.errorMsg_, this.lastError_);
-    if (this.lastError_ == remoting.Error.AUTHENTICATION_FAILED) {
+    l10n.localizeElementFromTag(this.errorMsg_, this.lastError_.tag);
+    if (this.lastError_.tag == remoting.Error.Tag.AUTHENTICATION_FAILED) {
       l10n.localizeElementFromTag(this.errorButton_,
                                   /*i18n-content*/'SIGN_IN_BUTTON');
     } else {
       l10n.localizeElementFromTag(this.errorButton_,
                                   /*i18n-content*/'RETRY');
     }
   } else {
     for (var i = 0; i < this.hosts_.length; ++i) {
       /** @type {remoting.Host} */
       var host = this.hosts_[i];
       // Validate the entry to make sure it has all the fields we expect and is
       // not the local host (which is displayed separately). NB: if the host has
       // never sent a heartbeat, then there will be no jabberId.
       if (host.hostName && host.hostId && host.status && host.publicKey &&
           (host.hostId != this.localHostSection_.getHostId())) {
         var hostTableEntry = new remoting.HostTableEntry(
             this.webappMajorVersion_,
             remoting.connectMe2Me,
             this.renameHost.bind(this),
             this.deleteHost_.bind(this));
         hostTableEntry.setHost(host);
         this.hostTableEntries_[i] = hostTableEntry;
         this.table_.appendChild(hostTableEntry.element());
       }
     }
   }
 
-  this.errorMsg_.parentNode.hidden = (this.lastError_ == '');
+  this.errorMsg_.parentNode.hidden = !this.lastError_.isError();
   if (noHostsRegistered) {
     this.showHostListEmptyMessage_(this.localHostSection_.canChangeState());
   }
 };
 
 /**
  * Displays a message to the user when the host list is empty.
  *
  * @param {boolean} hostingSupported
  * @return {void}
@@ skipping 74 matching lines @@
 
 /**
  * Set the state of the local host and localHostId if any.
  *
  * @param {remoting.HostController.State} state State of the local host.
  * @param {string?} hostId ID of the local host, or null.
  * @return {void} Nothing.
  */
 remoting.HostList.prototype.setLocalHostStateAndId = function(state, hostId) {
   var host = hostId ? this.getHostForId(hostId) : null;
-  this.localHostSection_.setModel(host, state, this.lastError_ !== '');
+  this.localHostSection_.setModel(host, state, this.lastError_.isError());
 };
 
 /**
  * Called by the HostControlled after the local host has been started.
  *
  * @param {string} hostName Host name.
  * @param {string} hostId ID of the local host.
  * @param {string} publicKey Public key.
  * @return {void} Nothing.
  */
@@ skipping 10 matching lines @@
   // Provide a version number to avoid warning about this dummy host being
   // out-of-date.
   localHost.hostVersion = String(this.webappMajorVersion_) + ".x"
   localHost.hostId = hostId;
   localHost.publicKey = publicKey;
   localHost.status = 'ONLINE';
   this.hosts_.push(localHost);
   this.save_();
   this.localHostSection_.setModel(localHost,
                                   remoting.HostController.State.STARTED,
-                                  this.lastError_ !== '');
+                                  this.lastError_.isError());
 };
 
 /**
  * Called when the user clicks the button next to the error message. The action
  * depends on the error.
  *
  * @private
  */
 remoting.HostList.prototype.onErrorClick_ = function() {
-  if (this.lastError_ == remoting.Error.AUTHENTICATION_FAILED) {
+  if (this.lastError_.tag == remoting.Error.Tag.AUTHENTICATION_FAILED) {
     remoting.handleAuthFailureAndRelaunch();
   } else {
     this.refresh(remoting.updateLocalHostState);
   }
 };
 
 /**
  * Save the host list to local storage.
  */
 remoting.HostList.prototype.save_ = function() {
   var items = {};
   items[remoting.HostList.HOSTS_KEY] = JSON.stringify(this.hosts_);
   chrome.storage.local.set(items);
   if (this.hosts_.length !== 0) {
     remoting.AppsV2Migration.saveUserInfo();
   }
 };
 
 /**
  * Key name under which Me2Me hosts are cached.
  */
 remoting.HostList.HOSTS_KEY = 'me2me-cached-hosts';
 
 /** @type {remoting.HostList} */
 remoting.hostList = null;