Converted remoting.Error from an enum to a class

remoting/webapp/crd/js/client_session.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * Class handling creation and teardown of a remoting client session.
  *
  * The ClientSession class controls lifetime of the client plugin
  * object and provides the plugin with the functionality it needs to
@@ skipping 31 matching lines @@
  *     when the client doesn't define any.
  * @constructor
  * @extends {base.EventSourceImpl}
  * @implements {base.Disposable}
  */
 remoting.ClientSession = function(host, signalStrategy, credentialsProvider,
                                   container, mode, defaultRemapKeys) {
   /** @private */
   this.state_ = remoting.ClientSession.State.CREATED;
 
-  /** @private */
+  /** @private {!remoting.Error} */
   this.error_ = remoting.Error.NONE;
 
   /** @private */
   this.host_ = host;
 
   /** @private */
   this.credentialsProvider_ = credentialsProvider;
 
   /** @private */
   this.uiHandler_ = new remoting.DesktopConnectedView(
@@ skipping 194 matching lines @@
  * @param {Array<string>} requiredCapabilities A list of capabilities
  *     required by this application.
  */
 remoting.ClientSession.prototype.createPluginAndConnect =
     function(onExtensionMessage, requiredCapabilities) {
   this.uiHandler_.createPluginAndConnect(onExtensionMessage,
                                          requiredCapabilities);
 };
 
 /**
- * @param {remoting.Error} error
+ * @param {!remoting.Error} error
  * @param {remoting.ClientPlugin} plugin
  */
 remoting.ClientSession.prototype.onPluginInitialized_ = function(
     error, plugin) {
-  if (error != remoting.Error.NONE) {
+  if (error.tag != remoting.Error.Tag.NONE) {
     this.resetWithError_(error);
   }
 
   this.plugin_ = plugin;
   plugin.setOnOutgoingIqHandler(this.sendIq_.bind(this));
   plugin.setOnDebugMessageHandler(this.onDebugMessage_.bind(this));
 
   plugin.setConnectionStatusUpdateHandler(
       this.onConnectionStatusUpdate_.bind(this));
   plugin.setRouteChangedHandler(this.onRouteChanged_.bind(this));
   plugin.setConnectionReadyHandler(this.onConnectionReady_.bind(this));
   plugin.setCapabilitiesHandler(this.onSetCapabilities_.bind(this));
   plugin.setGnubbyAuthHandler(
       this.processGnubbyAuthMessage_.bind(this));
   plugin.setCastExtensionHandler(
       this.processCastExtensionMessage_.bind(this));
 
   this.plugin_.connect(
       this.host_, this.signalStrategy_.getJid(), this.credentialsProvider_);
 };
 
 /**
- * @param {remoting.Error} error
+ * @param {!remoting.Error} error
  */
 remoting.ClientSession.prototype.resetWithError_ = function(error) {
   this.signalStrategy_.setIncomingStanzaCallback(null);
   this.removePlugin();
   this.error_ = error;
   this.setState_(remoting.ClientSession.State.FAILED);
 };
 
 /**
  * Deletes the <embed> element from the container, without sending a
  * session_terminate request.  This is to be called when the session was
  * disconnected by the Host.
  *
  * @return {void} Nothing.
  */
 remoting.ClientSession.prototype.removePlugin = function() {
   this.uiHandler_.removePlugin();
   this.plugin_ = null;
   remoting.desktopConnectedView = null;
 };
 
 /**
  * Disconnect the current session with a particular |error|.  The session will
  * raise a |stateChanged| event in response to it.  The caller should then call
  * dispose() to remove and destroy the <embed> element.
  *
- * @param {remoting.Error} error The reason for the disconnection.  Use
+ * @param {!remoting.Error} error The reason for the disconnection.  Use
  *    remoting.Error.NONE if there is no error.
  * @return {void} Nothing.
  */
 remoting.ClientSession.prototype.disconnect = function(error) {
-  var state = (error == remoting.Error.NONE) ?
+  var state = (error.tag == remoting.Error.Tag.NONE) ?
                   remoting.ClientSession.State.CLOSED :
                   remoting.ClientSession.State.FAILED;
 
   // The plugin won't send a state change notification, so we explicitly log
   // the fact that the connection has closed.
   this.logToServer.logClientSessionStateChange(state, error);
   this.error_ = error;
   this.setState_(state);
 };
 
@@ skipping 20 matching lines @@
 };
 
 /**
  * @return {remoting.ClientSession.State} The current state.
  */
 remoting.ClientSession.prototype.getState = function() {
   return this.state_;
 };
 
 /**
- * @return {remoting.Error} The current error code.
+ * @return {!remoting.Error} The current error code.
  */
 remoting.ClientSession.prototype.getError = function() {
   return this.error_;
 };
 
 /**
  * Called when the client receives its first frame.
  *
  * @return {void} Nothing.
  */
@@ skipping 166 matching lines @@
  * @private
  */
 remoting.ClientSession.prototype.setState_ = function(newState) {
   var oldState = this.state_;
   this.state_ = newState;
   var state = this.state_;
   if (oldState == remoting.ClientSession.State.CONNECTING) {
     if (this.state_ == remoting.ClientSession.State.CLOSED) {
       state = remoting.ClientSession.State.CONNECTION_CANCELED;
     } else if (this.state_ == remoting.ClientSession.State.FAILED &&
-        this.error_ == remoting.Error.HOST_IS_OFFLINE &&
+        this.error_.tag == remoting.Error.Tag.HOST_IS_OFFLINE &&
         !this.logHostOfflineErrors_) {
       // The application requested host-offline errors to be suppressed, for
       // example, because this connection attempt is using a cached host JID.
       console.log('Suppressing host-offline error.');
       state = remoting.ClientSession.State.CONNECTION_CANCELED;
     }
   } else if (oldState == remoting.ClientSession.State.CONNECTED &&
              this.state_ == remoting.ClientSession.State.FAILED) {
     state = remoting.ClientSession.State.CONNECTION_DROPPED;
   }
@@ skipping 123 matching lines @@
   if (this.state_ != remoting.ClientSession.State.CONNECTED) {
     return;
   }
   /** @type {remoting.ClientSession} */
   var that = this;
 
   /** @param {string} token */
   var sendToken = function(token) {
     remoting.clientSession.sendClientMessage('accessToken', token);
   };
-  /** @param {remoting.Error} error */
+  /** @param {!remoting.Error} error */
   var sendError = function(error) {
     console.log('Failed to refresh access token: ' + error);
   };
   remoting.identity.getNewToken().
       then(sendToken).
       catch(remoting.Error.handler(sendError));
   window.setTimeout(this.sendGoogleDriveAccessToken_.bind(this),
                     remoting.ACCESS_TOKEN_RESEND_INTERVAL_MS);
 };
 
@@ skipping 55 matching lines @@
  * @param {boolean} enable True to enable rendering.
  */
 remoting.ClientSession.prototype.enableDebugRegion = function(enable) {
   if (enable) {
     this.plugin_.setDebugDirtyRegionHandler(
         this.uiHandler_.handleDebugRegion.bind(this.uiHandler_));
   } else {
     this.plugin_.setDebugDirtyRegionHandler(null);
   }
 }