Converted remoting.Error from an enum to a class

remoting/webapp/app_remoting/js/app_remoting.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * This class implements the functionality that is specific to application
  * remoting ("AppRemoting" or AR).
  */
 
@@ skipping 163 matching lines @@
     url: that.runApplicationUrl(),
     onDone: parseAppHostResponse,
     oauthToken: token
   });
 };
 
 /**
  * Report an authentication error to the user. This is called in lieu of start()
  * if the user cannot be authenticated or if they decline the app permissions.
  *
- * @param {remoting.Error} error The failure reason.
+ * @param {!remoting.Error} error The failure reason.
  */
 remoting.AppRemoting.prototype.signInFailed = function(error) {
-  if (error == remoting.Error.CANCELLED) {
+  if (error.tag == remoting.Error.Tag.CANCELLED) {
     chrome.app.window.current().close();
     remoting.LoadingWindow.close();
   } else {
     this.handleError(error);
   }
 };
 
 /**
  * @return {string} Application product name to be used in UI.
  */
@@ skipping 52 matching lines @@
   // Cancel the ping when the connection closes.
   window.clearInterval(this.pingTimerId_);
 
   chrome.app.window.current().close();
 };
 
 /**
  * Called when the current session's connection has failed.
  *
  * @param {remoting.SessionConnector} connector
- * @param {remoting.Error} error
+ * @param {!remoting.Error} error
  * @return {void} Nothing.
  */
 remoting.AppRemoting.prototype.handleConnectionFailed = function(
     connector, error) {
   this.handleError(error);
 };
 
 /**
  * Called when the current session has reached the point where the host has
  * started streaming video frames to the client.
@@ skipping 55 matching lines @@
       this.contextMenu_.updateConnectionRTT(now - then);
       return true;
   }
 
   return false;
 };
 
 /**
  * Called when an error needs to be displayed to the user.
  *
- * @param {remoting.Error} errorTag The error to be localized and displayed.
+ * @param {!remoting.Error} errorTag The error to be localized and displayed.
  * @return {void} Nothing.
  */
 remoting.AppRemoting.prototype.handleError = function(errorTag) {
   console.error('Connection failed: ' + errorTag);
   remoting.LoadingWindow.close();
   remoting.MessageWindow.showErrorMessage(
       chrome.i18n.getMessage(/*i18n-content*/'CONNECTION_FAILED'),
       chrome.i18n.getMessage(/** @type {string} */ (errorTag)));
 };