Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 955273002: Fix PEImage tests to use a checked in binary. (Closed)

Created:
5 years, 10 months ago by Will Harris
Modified:
5 years, 9 months ago
CC:
chromium-reviews, grt+watch_chromium.org, erikwright+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : mark binaries binary #

Total comments: 2

Patch Set 3 : remove incorrect isolate entry #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -174 lines) Patch
M base/BUILD.gn View 2 chunks +2 lines, -4 lines 0 comments Download
M base/base.gyp View 2 chunks +2 lines, -3 lines 0 comments Download
M base/base_unittests.isolate View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
A base/test/data/pe_image/pe_image_test_32.dll View 1 Binary file 0 comments Download
A base/test/data/pe_image/pe_image_test_64.dll View 1 Binary file 0 comments Download
M base/win/pe_image_unittest.cc View 3 chunks +35 lines, -160 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Will Harris
PTAL
5 years, 10 months ago (2015-02-26 03:59:04 UTC) #2
rvargas (doing something else)
lgtm https://codereview.chromium.org/955273002/diff/2/base/win/pe_image_unittest.cc File base/win/pe_image_unittest.cc (right): https://codereview.chromium.org/955273002/diff/2/base/win/pe_image_unittest.cc#newcode11 base/win/pe_image_unittest.cc:11: #include "base/win/pe_image.h" nit: The rules keep changing, but ...
5 years, 10 months ago (2015-02-26 18:56:49 UTC) #3
Will Harris
https://codereview.chromium.org/955273002/diff/2/base/win/pe_image_unittest.cc File base/win/pe_image_unittest.cc (right): https://codereview.chromium.org/955273002/diff/2/base/win/pe_image_unittest.cc#newcode11 base/win/pe_image_unittest.cc:11: #include "base/win/pe_image.h" On 2015/02/26 18:56:49, rvargas wrote: > nit: ...
5 years, 10 months ago (2015-02-26 18:58:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/955273002/2
5 years, 10 months ago (2015-02-26 19:02:07 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/45839)
5 years, 10 months ago (2015-02-26 19:23:45 UTC) #8
Will Harris
I'll git cl land once the win bots are green - known issue with bots ...
5 years, 10 months ago (2015-02-26 19:31:09 UTC) #9
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/0fabf08b78b13d4bee202152b5cdb138d3cc74e4 Cr-Commit-Position: refs/heads/master@{#318313}
5 years, 9 months ago (2015-02-26 21:23:46 UTC) #10
Will Harris
5 years, 9 months ago (2015-02-26 21:24:01 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:20001) manually as
0fabf08b78b13d4bee202152b5cdb138d3cc74e4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698