Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 955263004: Make shelldb not crash. (Closed)

Created:
5 years, 9 months ago by eseidel
Modified:
5 years, 9 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make shelldb not crash. I clearly hadn't actually tested it. Sorry. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/dc5125f816e6b1d6c346c7292f11eb136bfd5019

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -12 lines) Patch
M sky/tools/shelldb View 5 chunks +14 lines, -11 lines 0 comments Download
M sky/tools/skypy/skyserver.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
eseidel
lgtm
5 years, 9 months ago (2015-03-03 19:33:56 UTC) #1
abarth-chromium
lgtm
5 years, 9 months ago (2015-03-03 20:06:36 UTC) #2
eseidel
5 years, 9 months ago (2015-03-03 20:50:02 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dc5125f816e6b1d6c346c7292f11eb136bfd5019 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698