Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 955263002: Rename mojo_type_converters.* to mojo_{host,proxy}_type_converters.* (Closed)

Created:
5 years, 10 months ago by Anand Mistry (off Chromium)
Modified:
5 years, 10 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename mojo_type_converters.* to mojo_{host,proxy}_type_converters.* Some versions of libtool will complain about having multiple files with the same name. BUG=461989 Committed: https://crrev.com/7ec58118d756b92c7a8a63d1cacdf9a6442b44bf Cr-Commit-Position: refs/heads/master@{#318194}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -270 lines) Patch
M net/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
M net/dns/host_resolver_mojo.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/dns/host_resolver_mojo_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/dns/mojo_host_resolver_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/dns/mojo_host_resolver_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + net/dns/mojo_host_type_converters.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + net/dns/mojo_host_type_converters.cc View 1 chunk +1 line, -1 line 0 comments Download
D net/dns/mojo_type_converters.h View 1 chunk +0 lines, -39 lines 0 comments Download
D net/dns/mojo_type_converters.cc View 1 chunk +0 lines, -97 lines 0 comments Download
M net/net.gyp View 1 chunk +4 lines, -4 lines 0 comments Download
M net/proxy/mojo_proxy_resolver_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/mojo_proxy_resolver_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + net/proxy/mojo_proxy_type_converters.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + net/proxy/mojo_proxy_type_converters.cc View 1 chunk +1 line, -1 line 0 comments Download
D net/proxy/mojo_type_converters.h View 1 chunk +0 lines, -29 lines 0 comments Download
D net/proxy/mojo_type_converters.cc View 1 chunk +0 lines, -83 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Anand Mistry (off Chromium)
5 years, 10 months ago (2015-02-26 03:47:02 UTC) #2
eroman
lgtm
5 years, 10 months ago (2015-02-26 04:31:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/955263002/1
5 years, 10 months ago (2015-02-26 05:13:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-26 06:03:13 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 06:03:42 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/7ec58118d756b92c7a8a63d1cacdf9a6442b44bf
Cr-Commit-Position: refs/heads/master@{#318194}

Powered by Google App Engine
This is Rietveld 408576698