Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 955243002: Remove RecordTypeFeedback() methods from some AST classes and move into typing.cc. (Closed)

Created:
5 years, 10 months ago by titzer
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove RecordTypeFeedback() methods from some AST classes and move into typing.cc. R=mvstanton@chromium.org BUG= Committed: https://crrev.com/5c7b7b919b50ba6e5827ad164968e94024f8a63b Cr-Commit-Position: refs/heads/master@{#26890}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -27 lines) Patch
M src/ast.h View 4 chunks +8 lines, -2 lines 0 comments Download
M src/ast.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M src/typing.cc View 2 chunks +17 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
titzer
5 years, 10 months ago (2015-02-26 00:51:38 UTC) #1
Jakob Kummerow
LGTM (stealing from Michael who is OOO)
5 years, 10 months ago (2015-02-26 14:35:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/955243002/1
5 years, 10 months ago (2015-02-26 16:42:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-26 18:34:47 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 18:35:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c7b7b919b50ba6e5827ad164968e94024f8a63b
Cr-Commit-Position: refs/heads/master@{#26890}

Powered by Google App Engine
This is Rietveld 408576698